Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli-hooks): output node warnings to stderr for debugging outputs #2152

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Feb 22, 2025

Summary

This PR reverts changes made in #2096 that hide Node warnings.

The latest Slack CLI version v2.33.0 has improved handling of stderr and will now write unexpected output to debug logs instead of erroring when parsing hook responses! 🎉

Preview

node_warnings.mov

Reviewers

With these changes checked out and installed to an app using @slack/cli-hooks, run the following commands with Node v23.2.0:

$ slack manifest     # Get an app manifest
$ slack manifest -v  # Review debug logs

Requirements

@zimeg zimeg added semver:patch enhancement M-T: A feature request for new functionality pkg:cli-hooks applies to `@slack/cli-hooks` labels Feb 22, 2025
@zimeg zimeg added this to the [email protected] milestone Feb 22, 2025
@zimeg zimeg requested a review from mwbrooks February 22, 2025 21:58
@zimeg zimeg self-assigned this Feb 22, 2025
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (15e1ce0) to head (fb40920).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2152      +/-   ##
==========================================
- Coverage   91.94%   91.94%   -0.01%     
==========================================
  Files          38       38              
  Lines       10330    10328       -2     
  Branches      652      652              
==========================================
- Hits         9498     9496       -2     
  Misses        820      820              
  Partials       12       12              
Flag Coverage Δ
cli-hooks 95.23% <100.00%> (-0.02%) ⬇️
cli-test 94.76% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.82% <ø> (ø)
web-api 96.88% <ø> (ø)
webhook 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM!

🚀 Let's publish a release of this on Monday!

@zimeg
Copy link
Member Author

zimeg commented Feb 27, 2025

@mwbrooks Thanks so much! I must've been following a different calendar, but am excited to be outputting warnings that do appear 👻

@zimeg zimeg merged commit 9048fd9 into main Feb 27, 2025
57 checks passed
@zimeg zimeg deleted the zimeg-feat-cli-hooks-remove-node-warnings branch February 27, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality pkg:cli-hooks applies to `@slack/cli-hooks` semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants