Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cancel test jobs with a timeout after running for four minutes #2175

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Mar 12, 2025

Summary

This PR changes the test timeout time from "10" minutes to "4" minutes to avoid hanging after failed tests in some cases - related to #2138 #2159.

Notes

Most successful tests tend to finish in ~2 minutes, with 1/200 of the last successful runs taking 4:08 which seems to've been a flake...

IMO this doesn't fix the related issues, but it makes rerunning the tests faster in the meantime 😅

Requirements

@zimeg zimeg added tests M-T: Testing work only github_actions Pull requests that update GitHub Actions code labels Mar 12, 2025
@zimeg zimeg self-assigned this Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (a0e79f9) to head (727f57f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2175   +/-   ##
=======================================
  Coverage   91.94%   91.94%           
=======================================
  Files          38       38           
  Lines       10328    10328           
  Branches      652      652           
=======================================
  Hits         9496     9496           
  Misses        820      820           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.76% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.82% <ø> (ø)
web-api 96.88% <ø> (ø)
webhook 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WilliamBergamin WilliamBergamin merged commit f3cef62 into main Mar 13, 2025
57 checks passed
@WilliamBergamin WilliamBergamin deleted the zimeg-ci-timeout-fast branch March 13, 2025 21:05
@zimeg
Copy link
Member Author

zimeg commented Mar 13, 2025

@WilliamBergamin 🚀 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants