Add WithMinLenPasswordFile pemutil option #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraino
requested changes
Feb 26, 2025
pemutil/pem.go
Outdated
Comment on lines
179
to
180
| re := regexp.MustCompile(`\s+`) | ||
| trimmed := re.ReplaceAllString(string(b), "") |
There was a problem hiding this comment.
The method utils.ReadPasswordFromFile already returns the password properly trimmed. Don't do anything else.
pemutil/pem.go
Outdated
| // WithMinLenPasswordFile is a method that adds the password in a file to the context. | ||
| // If the password does not meet the minimum length requirement an error is returned. | ||
| // If minimum length input is <=0 then the requirement is ignored. | ||
| func WithMinLenPasswordFile(filename string, minlen int) Options { |
There was a problem hiding this comment.
Perhaps we want to pass variadic options to WithPasswordFile(filename) for example WithPasswordFile(filename, ValidateMinLength(10)) you could do crazy things like
WithPasswordFile(filename, func(pass []byte) error {
if bytes.Contains(pass, []byte{'a'}) {
return errors.New("password cannot contain the letter `a`")
}
return nil
})There was a problem hiding this comment.
I'm not sure this is a good idea. It's not clear if the variadic options should be applied to the file or to the resulting password. For example an option that validated the ownership on the file would be applied before the password was read. Some of the options may need to be applied before the password is read (on the file), and some after.
maraino
previously approved these changes
Feb 27, 2025
maraino
reviewed
Feb 27, 2025
Co-authored-by: Mariano Cano <[email protected]>
maraino
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.