codec: fix parsing of optional values, add a special type codec for OnRampAddress
#1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
force-pushed
the
ccip-messaging-test
branch
from
e559316 to
94fd376
Compare
archseer
force-pushed
the
ccip-messaging-test
branch
from
94fd376 to
0fea72b
Compare
archseer
force-pushed
the
ccip-messaging-test
branch
from
0fea72b to
be2e23f
Compare
archseer
commented
Feb 27, 2025
| @@ -30,7 +30,7 @@ func TestNewIDLAccountCodec(t *testing.T) { | |||
| bts, err := entry.Encode(ctx, expected, testutils.TestStructWithNestedStruct) | |||
|
|
|||
| // length of fields + discriminator | |||
| require.Equal(t, 262, len(bts)) | |||
| require.Equal(t, 263, len(bts)) | |||
There was a problem hiding this comment.
This is because we were actually encoding the option types incorrectly
|
EasterTheBunny
approved these changes
Feb 27, 2025
amit-momin
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.