update libocr, solana, terra #6473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
reviewed
Apr 20, 2022
jmank88
reviewed
Apr 20, 2022
aalu1418
requested review from
alexroan,
chainchad,
HenryNguyen5,
javuto,
jkongie and
samsondav
as code owners
jmank88
previously approved these changes
Apr 20, 2022
jmank88
reviewed
Apr 20, 2022
| @@ -312,6 +313,7 @@ require ( | |||
| golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac // indirect | |||
| google.golang.org/genproto v0.0.0-20220107163113-42d7afdf6368 // indirect | |||
| google.golang.org/grpc v1.43.0 // indirect | |||
| gopkg.in/guregu/null.v2 v2.1.2 // indirect | |||
There was a problem hiding this comment.
Oh wait, we have v4 already - should we be aligned on that?
There was a problem hiding this comment.
yeah that would be good...trying to figure out where v2 started showing up
There was a problem hiding this comment.
actually, not from solana/terra/libocr, and can't figure out where....
$ go mod why gopkg.in/guregu/null.v2
# gopkg.in/guregu/null.v2
(main module does not need package gopkg.in/guregu/null.v2)
There was a problem hiding this comment.
Could be indirect and test only? golang/go#30206
There was a problem hiding this comment.
...yeah i'm struggling to find this too. will give it another shot tomorrow 🙃
i did find this tho:
go mod why gopkg.in/guregu/null.v2/zero
# gopkg.in/guregu/null.v2/zero
github.com/smartcontractkit/chainlink/core/cmd
github.com/manyminds/api2go/jsonapi
github.com/manyminds/api2go/jsonapi.test
gopkg.in/guregu/null.v2/zero
go mod why -m gopkg.in/guregu/null.v2
# gopkg.in/guregu/null.v2
github.com/smartcontractkit/chainlink/core/cmd
github.com/manyminds/api2go/jsonapi
github.com/manyminds/api2go/jsonapi.test
gopkg.in/guregu/null.v2/zero
There was a problem hiding this comment.
notes:
- this likely happened because of bumping the core version in solana & terra repos to core 1.3 so go mod chose differently
aalu1418
force-pushed
the
update/libocr-terra-solana
branch
from
11e76b4 to
e8a0655
Compare
aalu1418
force-pushed
the
update/libocr-terra-solana
branch
from
e8a0655 to
2148c2c
Compare
jmank88
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.