Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated GTStructure to use pointers to items instead of value receivers. #1

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

jaroslaw-bochniak
Copy link

This is a breaking change as the public method signatures and main type has been modified.

  • allows creation of the structure and flexible mutating it before actual printing
  • pointer receiver should be more efficient for large structures
  • added simple test + test resources

This is a breaking change as the public method signatures and main type has been modified.

- allows creation of the structure and flexible mutating it before actual printing
- pointer receiver should be more efficient for large structures
- added simple test + test resources
Copy link

@mslusarczyk mslusarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@kasinskim kasinskim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@jaroslaw-bochniak jaroslaw-bochniak merged commit 49f7650 into master Mar 20, 2018
@vanta vanta deleted the pointers-in-tree-structure branch September 16, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants