Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keep_alive_timeout option #60

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

greg-freewave
Copy link

Using this library our client webserver is getting ping_timeouts every now and then and before writing some extra code we wanted to try extending the timeout period to see how that changes the frequency of ping_timeouts. Not sure if this is the right place to store this option, happy to change it to whatever is best. Thanks!

@greg-freewave greg-freewave force-pushed the keep_alive_timeout_option branch from f4c300e to 0edf1e2 Compare January 14, 2025 20:08
@greg-freewave greg-freewave force-pushed the keep_alive_timeout_option branch from 0edf1e2 to c57216d Compare January 16, 2025 23:12
so library users can adjust the keep_alive response timeout.
@greg-freewave greg-freewave force-pushed the keep_alive_timeout_option branch from c57216d to e8f73b4 Compare January 16, 2025 23:14
@greg-freewave
Copy link
Author

@jfcloutier ping :)

Copy link
Collaborator

@jfcloutier jfcloutier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Greg!

@jfcloutier jfcloutier merged commit 2c67bc1 into smartrent:main Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants