Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promise resolve/reject toast disappearing #25

Closed
JoaoPedroAS51 opened this issue Oct 9, 2023 · 2 comments · Fixed by #26 or #28
Closed

Promise resolve/reject toast disappearing #25

JoaoPedroAS51 opened this issue Oct 9, 2023 · 2 comments · Fixed by #26 or #28
Assignees
@smastrom
Labels
bug Something isn't working

Comments

@JoaoPedroAS51
Copy link

Hi! I'm facing an issue with the promise toast.

Let's say I have set a duration of 2000ms to my toasts. If the promise takes longer than 2000ms, when I call resolve/reject, the success/error toast disappear immediately.

Note: the loading toast don't disappear because it's set to Infinity
smastrom added a commit that referenced this issue Oct 9, 2023
@smastrom
Notivue Core - Fix global options overriding promise duration - #25
3c88799
@smastrom smastrom self-assigned this Oct 9, 2023
@smastrom smastrom added the bug Something isn't working label Oct 9, 2023
@smastrom smastrom linked a pull request Oct 9, 2023 that will close this issue
v1.4.1 #26
Merged
smastrom added a commit that referenced this issue Oct 9, 2023
@smastrom
v1.4.1 (#26)
b3d6ccd 
* up deps, fix husky script

* Notivue Core - Fix global options overriding promise duration - #25

* fix copilot jsdoc typo

* release v1.4.1
@smastrom smastrom linked a pull request Oct 9, 2023 that will close this issue
v1.4.1 #28
Merged
smastrom added a commit that referenced this issue Oct 9, 2023
@smastrom
v1.4.1 (#28)
c851429 
* up deps, fix husky script

* Notivue Core - Fix global options overriding promise duration - #25

* fix copilot jsdoc typo

* release v1.4.1

* Notivue Core - Prevent overriding promise duration via push options

* Tests - Streamline Notivue test component
@smastrom
Copy link
Owner

smastrom commented Oct 9, 2023

Hi @JoaoPedroAS51, most likely someone already faced this critical issue in the past and didn't reported. But you did, so thank you, seriously.

Please update to latest version:

pnpm add notivue@latest

And thank you again.

@JoaoPedroAS51
Copy link
Author

Hey! Thank you for the quick fix! Glad I could help in some way. And thank you so much for your awesome lib! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smastrom smastrom

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.4.1 smastrom/notivue
v1.4.1 smastrom/notivue
2 participants
@JoaoPedroAS51 @smastrom