Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate autofill to async/await #41

Closed
Firehed opened this issue Aug 6, 2024 · 0 comments · Fixed by #44
Closed

Migrate autofill to async/await #41

Firehed opened this issue Aug 6, 2024 · 0 comments · Fixed by #44
Milestone

Comments

@Firehed
Copy link
Contributor

Firehed commented Aug 6, 2024

The initial callback-based API was made on some incorrect assumptions on how async/await works in a javascript context. Instead, the autofill API should also use promises.

Depending on naming, this could be a breaking change - although it'd also be possible to do this in a compatible way. Since this is pre-1.0, this isn't necessarily a huge concern; all else being equal I'd prefer to have only a single code path to maintain and support.

Note that there are examples on the website and documentation for autofill using the callback design, so they should also get updated to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant