Update to bytes 1.0 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Dec 24, 2020
| for x in data.iter_mut() { | ||
| *x.as_mut_ptr() = 0; | ||
| for i in 0..data.len() { | ||
| data.write_byte(i, 0); |
There was a problem hiding this comment.
Or maybe instead of that we can do something with bytes::buf::UninitSlice here without having to initialize everything first?
sdroege
approved these changes
Dec 24, 2020
sdroege
reviewed
Dec 24, 2020
Cargo.toml
Outdated
| @@ -12,4 +12,4 @@ documentation = "https://docs.rs/input_buffer/0.3.1" | |||
| version = "0.3.1" | |||
There was a problem hiding this comment.
AFAIU this changes the API so the next release should be 0.4.0
|
@application-developer-DA is there anything blocking this PR from being merged? There's a few upstream crates depending on it so would be great if we could get it in / release. Thank you! |
daniel-abramov
approved these changes
Dec 29, 2020
|
Thank you @application-developer-DA. Do you also mind releasing 0.4.0 to crates? |
|
Sure. @agalakhov , could you please publish it? (or give me permissions to do so, I'm not an owner of the crate ;) |
|
Bump @agalakhov it'd be great if you could do the release / give DA perms! Thank you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.