Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP: Don't serve Webfinger for accounts we don't own #1025

Closed
snarfed opened this issue May 6, 2024 · 3 comments
Closed

AP: Don't serve Webfinger for accounts we don't own #1025

snarfed opened this issue May 6, 2024 · 3 comments

Comments

@snarfed
Copy link
Owner

snarfed commented May 6, 2024

Right now, a bit embarrassingly, we serve Webfinger responses for any addresses that comes in, regardless of whether we actually own it. Example: /.well-known/webfinger?resource=acct:[email protected], which we oddly get ~1-2qps for, steady state, from a ton of different instances. We should return 404 (I assume?) instead for addresses we don't own.

@snarfed snarfed added the now label May 6, 2024
@snarfed
Copy link
Owner Author

snarfed commented May 7, 2024

Ah right. This isn't quite as easy because of our support for web sites on arbitrary domains. We'd need to detect when a domain is an AP instance so that we know when to serve a 400 and not try to handle them as a normal web site.

@snarfed
Copy link
Owner Author

snarfed commented May 7, 2024

Manual workaround for now is to just opt out any problematic domains here.

@snarfed
Copy link
Owner Author

snarfed commented May 8, 2024

Related: #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant