-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When creating a new ATProto account, handle existing DNS record #1072
Labels
Comments
We still see a steady trickle of these, roughly one a day on average: https://console.cloud.google.com/errors/detail/COibqNv9r7ynFg?project=bridgy-federated |
I wonder if #1063 will mostly or entirely prevent this. |
Nope, we're still seeing a trickle. |
snarfed
added a commit
that referenced
this issue
Jul 24, 2024
Done! And I fixed (I think) pretty much everyone who hit this in the last 30d or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, when we create a new ATProto repo and DID, if our
_atproto
DNS record for handle resolution already exists, we crash. We should handle that and recover instead. Example log below; exception isgoogle.api_core.exceptions.Conflict
. Docs don't help much. Haven't found a way to tell it to overwrite/replace existing records, so I may need to either catch the exception or look up the record first. cc @gabbomanThe text was updated successfully, but these errors were encountered: