Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finish unifying webmention receiving logic into Protocol.receive #529

Closed
Tracked by #512
snarfed opened this issue Jun 4, 2023 · 2 comments
Closed
Tracked by #512

finish unifying webmention receiving logic into Protocol.receive #529

snarfed opened this issue Jun 4, 2023 · 2 comments

Comments

@snarfed
Copy link
Owner

snarfed commented Jun 4, 2023

Specifically, web.webmention_task. Will probably be ugly and tedious and a bit awkward. Important, but not urgent.
@snarfed snarfed mentioned this issue Jun 4, 2023
Closed
40 tasks
@snarfed
Copy link
Owner Author

snarfed commented Jun 15, 2023

Terminology:

  • recipient is a user or object
  • target is a string protocol endpoint that an activity can be delivered to, eg an AP inbox, Nostr relay, webmention target page

Activity Objects have recipients, recipients have one or more targets.

  • Protocol.deliver(obj) is protocol-agnostic, has activity processing logic, determines recipients, collects their targets, and calls send
  • Protocol.targets_for(obj) is per-protocol
  • Protocol.send(obj, target) is per-protocol

snarfed added a commit that referenced this issue Jun 16, 2023
@snarfed
add Protocol.target_for()
374354a 
for #529
snarfed added a commit that referenced this issue Jun 21, 2023
@snarfed
generalize wm => AP delivery logic across protocols!
9467f38 
phew! another tough one. #529
This was referenced Jun 21, 2023
Closed
Closed
snarfed added a commit that referenced this issue Jun 27, 2023
@snarfed
generalize Protocol.accept_follow, other bug fixes in Protocol.receive
9140318 
for #529, fixes https://console.cloud.google.com/errors/detail/CMbJ6a6j56LErwE;time=P30D?project=bridgy-federated
snarfed added a commit that referenced this issue Jun 29, 2023
@snarfed
start merging web.webmention_task into Protocol.receive
6498f83 
for #529
snarfed added a commit that referenced this issue Jun 29, 2023
@snarfed
merge Protocol.receive: follow tweaks, like test
cdcee15 
for #529
snarfed added a commit that referenced this issue Jun 29, 2023
@snarfed
lots more on merging Protocol/Web receive and deliver
8c24dcf 
for #529
snarfed added a commit that referenced this issue Jun 29, 2023
@snarfed
start merging web.webmention_task into Protocol.receive
7ae47b6 
for #529
snarfed added a commit that referenced this issue Jun 29, 2023
@snarfed
merge Protocol.receive: follow tweaks, like test
51257fe 
for #529
snarfed added a commit that referenced this issue Jun 29, 2023
@snarfed
lots more on merging Protocol/Web receive and deliver
ff691d1 
for #529
snarfed added a commit that referenced this issue Jun 29, 2023
@snarfed
merging Protocol/Web receive: handle bare reply objects
e1e0803 
for #529
snarfed added a commit that referenced this issue Jun 30, 2023
@snarfed
start merging web.webmention_task into Protocol.receive
c6d0d58 
for #529
snarfed added a commit that referenced this issue Jun 30, 2023
@snarfed
merge Protocol.receive: follow tweaks, like test
b637d7e 
for #529
snarfed added a commit that referenced this issue Jun 30, 2023
@snarfed
lots more on merging Protocol/Web receive and deliver
889352c 
for #529
snarfed added a commit that referenced this issue Jun 30, 2023
@snarfed
merging Protocol/Web receive: handle bare reply objects
ab483a6 
for #529
snarfed added a commit that referenced this issue Jun 30, 2023
@snarfed
merging Protocol/Web receive: more follow tests
80bc092 
for #529
snarfed added a commit that referenced this issue Jun 30, 2023
@snarfed
merging Protocol/Web receive: tweaks to Object.users, Object.labels
e7b451c 
for #529
snarfed added a commit that referenced this issue Jul 1, 2023
@snarfed
merging Protocol/Web receive: tweak error handling, de-dupe target URLs
663a66e 
for #529
snarfed added a commit that referenced this issue Jul 1, 2023
@snarfed
merging Protocol/Web receive: move _deliver, _targets from Web to Pro…
00c05f2 
…tocol

for #529
snarfed added a commit that referenced this issue Jul 1, 2023
@snarfed
merging Protocol/Web receive: improve logic for bare objects
c120de9 
for #529
@snarfed snarfed mentioned this issue Jul 2, 2023
Closed
snarfed added a commit that referenced this issue Jul 2, 2023
@snarfed
Summary merging Protocol/Web receive: change receive to take Object
c22c2b1 
for #529
snarfed added a commit that referenced this issue Jul 2, 2023
@snarfed
merging Protocol/Web receive: tests for repost, update reply
70378c6 
for #529
snarfed added a commit that referenced this issue Jul 2, 2023
@snarfed
merging Protocol/Web receive: reposts, deletes
09bbc64 
for #529
snarfed added a commit that referenced this issue Jul 3, 2023
@snarfed
merging Protocol/Web receive: test_send_error
b80c729 
for #529
snarfed added a commit that referenced this issue Jul 3, 2023
@snarfed
start merging web.webmention_task into Protocol.receive
4876681 
for #529
snarfed added a commit that referenced this issue Jul 3, 2023
@snarfed
merge Protocol.receive: follow tweaks, like test
1a57ba9 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
lots more on merging Protocol/Web receive and deliver
54881ea 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging Protocol/Web receive: handle bare reply objects
aeeea55 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging Protocol/Web receive: more follow tests
83f069a 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging Protocol/Web receive: tweaks to Object.users, Object.labels
d0d6a13 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging Protocol/Web receive: tweak error handling, de-dupe target URLs
ee4da35 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging Protocol/Web receive: move _deliver, _targets from Web to Pro…
4f8bcf9 
…tocol

for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging Protocol/Web receive: improve logic for bare objects
6157f3f 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
Summary merging Protocol/Web receive: change receive to take Object
ee3a596 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging Protocol/Web receive: tests for repost, update reply
2ea78a8 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging Protocol/Web receive: reposts, deletes
903f26b 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging Protocol/Web receive: test_send_error
26a63e1 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging Protocol/Web receive: use actor for deletes, not g.user
79c1f71 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging Protocol/Web receive: start to work through test_web
568681a 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging Protocol/Web receive: minor fix for extracting activity id
5f4d675 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging receive: delivery bug fix, stop suppressing webmention send e…
9c62786 
…rrors

for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging receive: Object.users bug fix, fix most test_activitypub tests
79dd28e 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging receive: propagate new/changed from receive into new Object
56ebdba 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging receive: if incoming object has no id (eg web/mf2), default t…
2c861db 
…o URL

for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging receive: check for already seen activity ids more carefully
911dc56 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging receive: Object.as1: postprocess mf2, if no id, use url
89ff89e 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging receive: Web.fetch: default actor/author to home page URL
a2ed0af 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging receive: handle follow with multiple objects (followees)
0d7df6d 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging receive: Web: handle ValueError raised by protocol.receive
15557dc 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging receive: skip same-domain targets
605742a 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging receive: implement mentions, deliver to mentioned users
174c55a 
for #529
snarfed added a commit that referenced this issue Jul 11, 2023
@snarfed
merging receive: bug fix for same domain check: normalize target URLs…
815ae95 
… earlier

for #529, a3f99a8
snarfed added a commit that referenced this issue Jul 13, 2023
@snarfed
merging receive: skip same-protocol deliveries and Followers
0e47918 
for #529
snarfed added a commit that referenced this issue Jul 15, 2023
@snarfed
merging receive: Web: skip sending wms for normal posts (ie not repli…
8903273 
…es etc)

for #529
@snarfed
Copy link
Owner Author

snarfed commented Jul 18, 2023

Shipped!

@snarfed snarfed closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snarfed