fix: ignore dependencies in virtualenv #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admons
reviewed
Feb 8, 2021
admons
reviewed
Feb 8, 2021
admons
reviewed
Feb 8, 2021
lib/poetry-dep-graph-builder.ts
Outdated
| pkgName: string, | ||
| pkgSpecs: PoetryLockFileDependency[], | ||
| ): PoetryLockFileDependency { | ||
| const pkgLockInfo = pkgSpecs.find((lockItem) => { |
There was a problem hiding this comment.
const pkgLockInfo = pkgSpecs.find((lockItem) =>
lockItem.name.toLowerCase() === pkgName.toLowerCase()
);
There was a problem hiding this comment.
Just to clarify, you mean to remove the return?
admons
reviewed
Feb 8, 2021
admons
reviewed
Feb 8, 2021
admons
reviewed
Feb 8, 2021
admons
reviewed
Feb 8, 2021
dtrunley-snyk
changed the title
dtrunley-snyk
force-pushed
the
bug/ignore-dependencies-in-virtualenv
branch
from
256ca6b to
ea344c1
Compare
admons
approved these changes
Feb 9, 2021
|
Looking great! |
dtrunley-snyk
changed the title
|
🎉 This PR is included in version 1.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Poetry uses the virtualenv to create an environment and this comes with these packages pre-installed, therefore they won't be listed in the lockfile as a dependency but it won't have its own metadata entry within the lockfile. This change prevents us trying to traverse the lockfile for those specific dependencies.
See: python-poetry/poetry#3075 (comment)
Also features a small refactor that better isolates the method to be able to test via unit tests rather than having to add a fixture for each scenario / writing custom manifest and lockfiles to mimic the scenario in a "unit" test, so it should make subsequent changes easier to test with less code. The refactor looks larger than it is as it involves the bulk of index being moved to a new file.
More information