Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VectorLayer type prop and changed layerMixin before prop to String #81

Closed
wants to merge 4 commits into from

Conversation

luizotcarvalho
Copy link

I noticed that prop type on VectorLayer is missing and type fill was set every time (even if was defined as outline), and another problem was that mapboxgl is expecting a string on the before param of addLayer method and was typed as object on layerMixin props

@luizotcarvalho
Copy link
Author

And one more thing, the VectorLayer can only be used when url prop was set, but url prop is not required. So I moved alongside optional props when creating the source.

@soal
Copy link
Owner

soal commented Feb 16, 2019

I integrated your code manually in version 0.2, so I close this. Thank you for your contribution!

@soal soal closed this Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants