Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect tls stream and use https scheme instead of provided tcp #192

Closed
LucioFranco opened this issue Sep 13, 2019 · 2 comments
Closed

Detect tls stream and use https scheme instead of provided tcp #192

LucioFranco opened this issue Sep 13, 2019 · 2 comments

Comments

@LucioFranco
Copy link
Contributor

When attempting to use shiplift in a circleci environment with hyper, it must use tcp to connect to the remote docker daemon. This requires tls via the docker docs. The issue arises here https://github.com/softprops/shiplift/blob/master/src/transport.rs#L166 when the tcp:// scheme is copied. The real problem is that hyper's version checking requires the use of https instead of tcp directly. Thus the fix here is to replace the scheme only when encrypted.

Reference failing tests in vectordotdev/vector#787

@elihunter173
Copy link
Contributor

Should this issue still be open?

@LucioFranco
Copy link
Contributor Author

I think its been fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants