Replace host str to use https if encrypted #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Could we add a little code comment above these lines to capture the context. I could see my future self coming back to this a year from now and asking "why?" |
|
@softprops Sorry for the delay I've added a comment, if we could get a release that would be very appreciated, let me know what I can do to help! |
|
Thanks. I'm gonna shoot for at least this weekend. |
|
Thank you Doug <3 |
thomaseizinger
added a commit
to comit-network/create-comit-app
that referenced
this pull request
Dec 10, 2019
The recent release of shiplift (0.6) contains a patch a takes care of the logic that we previously applied ourselves: softprops/shiplift#193
bors bot
added a commit
to comit-network/create-comit-app
that referenced
this pull request
Dec 12, 2019
282: Remove shiplift host trickery r=mergify[bot] a=thomaseizinger The recent release of shiplift (0.6) contains a patch a takes care of the logic that we previously applied ourselves: softprops/shiplift#193 @luckysori could you please test this one manually on a Windows machine with docker toolbox? @D4nte / @bonomat or @da-kami please test if this still works on Mac. You can download the binaries from the GitHub actions run here (top right): https://github.com/comit-network/create-comit-app/pull/282/checks?check_run_id=341806523 Co-authored-by: Thomas Eizinger <[email protected]>
thomaseizinger
added a commit
to comit-network/create-comit-app
that referenced
this pull request
Dec 12, 2019
The recent release of shiplift (0.6) contains a patch a takes care of the logic that we previously applied ourselves: softprops/shiplift#193
bors bot
added a commit
to comit-network/create-comit-app
that referenced
this pull request
Dec 17, 2019
282: Remove shiplift host trickery r=bonomat a=thomaseizinger The recent release of shiplift (0.6) contains a patch a takes care of the logic that we previously applied ourselves: softprops/shiplift#193 @luckysori could you please test this one manually on a Windows machine with docker toolbox? @D4nte / @bonomat or @da-kami please test if this still works on Mac. You can download the binaries from the GitHub actions run here (top right): https://github.com/comit-network/create-comit-app/pull/282/checks?check_run_id=341806523 Co-authored-by: Thomas Eizinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During our testing in vectordotdev/vector#787 we found that there is an issue with hyper connecting to a tls connected docker engine that provided a host url of
tcp://.... I found the way to fix this was to replace thetcpscheme withhttps. This seems to work for when encryptedtcpstreams are active. The error hyper produces was a version parse error which seemed odd. This seemed to do the trick.Related to #192