Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Paper references from CIs #7134

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions .github/workflows/expo-devclient-build-check-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,26 @@ on:
workflow_dispatch:

jobs:
build_ios:
build:
if: github.repository == 'software-mansion/react-native-reanimated'
runs-on: ${{ matrix.platform == 'iOS' && 'macos-14' || 'ubuntu-latest' }}
strategy:
matrix:
react-native-architecture: ['Paper', 'Fabric']
platform: ['iOS', 'Android']
fail-fast: false
env:
APP_NAME: ExpoApp
EXPO_TAG: latest
concurrency:
group: ${{ matrix.platform }}-expo-dev-client-${{ matrix.react-native-architecture }}-${{ github.ref }}
group: ${{ matrix.platform }}-expo-dev-client-${{ github.ref }}
cancel-in-progress: true
steps:
- name: Check out reanimated repository
uses: actions/checkout@v4
- name: Setup Yarn
# Sometimes `npx @react-native-community/cli init` fails at random.
# Pre-installing it with Yarn seems to improve stability.
run: corepack enable && yarn set version stable
- name: Setup Java 17
if: ${{ matrix.platform == 'Android' }}
uses: actions/setup-java@v3
Expand All @@ -40,12 +43,8 @@ jobs:
with:
ruby-version: '3.3' # Not needed with a `.ruby-version` or `.tool-versions`
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- name: Create Expo app (Paper)
if: ${{ matrix.react-native-architecture == 'Paper' }}
- name: Create Expo app
run: npx create-expo-app@latest ${{ env.APP_NAME }}
- name: Create Expo app (Fabric)
if: ${{ matrix.react-native-architecture == 'Fabric' }}
run: npx create-expo-app@latest ${{ env.APP_NAME }} -e with-new-arch
- name: Load Expo tag
working-directory: ${{ env.APP_NAME }}
run: |
Expand All @@ -58,20 +57,32 @@ jobs:
- name: Setup configuration
working-directory: ${{ env.APP_NAME }}
run: node ${{ env.SCRIPT_PATH }} setBundleIdentifier
- name: Setup Yarn Modern in app
working-directory: ${{ env.APP_NAME }}
run: |
touch yarn.lock
yarn set version berry
yarn config set nodeLinker node-modules
- name: Install Worklets
working-directory: ${{ env.APP_NAME }}
run: yarn add "react-native-worklets@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-worklets&commit=${{ github.sha }}"
- name: Install Reanimated
working-directory: ${{ env.APP_NAME }}
run: npm install react-native-reanimated@nightly
run: yarn add react-native-reanimated@nightly
- name: Expo prebuild
working-directory: ${{ env.APP_NAME }}
run: npx expo prebuild
- name: Install pods
if: ${{ matrix.platform == 'iOS' }}
working-directory: ${{ env.APP_NAME }}/ios
run: bundle install && bundle exec pod install
run: pod install
- name: Install React Native
working-directory: ${{ env.APP_NAME }}
run: yarn add @react-native-community/cli
- name: Build app (iOS)
working-directory: ${{ env.APP_NAME }}
if: ${{ matrix.platform == 'iOS' }}
run: yarn react-native run-ios --terminal='Terminal'
run: yarn rnc-cli run-ios --terminal='Terminal'
- name: Build app (Android)
working-directory: ${{ env.APP_NAME }}/android
if: ${{ matrix.platform == 'Android' }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,24 @@ on:
workflow_dispatch:

jobs:
build_ios:
build:
if: github.repository == 'software-mansion/react-native-reanimated'
runs-on: ${{ matrix.platform == 'iOS' && 'macos-14' || 'ubuntu-latest'}}
strategy:
matrix:
react-native-architecture: ['Paper', 'Fabric']
platform: ['iOS', 'Android']
fail-fast: false
env:
REACT_NATIVE_TAG: nightly
APP_NAME: app
concurrency:
group: ${{ matrix.platform }}-react-native-nightly-${{ matrix.react-native-architecture }}-${{ github.ref }}
group: ${{ matrix.platform }}-react-native-nightly-${{ github.ref }}
cancel-in-progress: true
steps:
- name: Setup Yarn
# Sometimes `npx @react-native-community/cli init` fails at random.
# Pre-installing it with Yarn seems to improve stability.
run: corepack enable && yarn init
run: corepack enable && yarn set version stable
- name: Set up JDK 18
if: ${{ matrix.platform == 'Android' }}
uses: actions/setup-java@v3
Expand All @@ -54,18 +53,13 @@ jobs:
- name: Install Reanimated
working-directory: ${{ env.APP_NAME }}
run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}"
- name: Install Paper Pods (iOS)
if: ${{ matrix.react-native-architecture == 'Paper' && matrix.platform == 'iOS' }}
- name: Install Worklets
working-directory: ${{ env.APP_NAME }}
run: yarn add "react-native-worklets@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-worklets&commit=${{ github.sha }}"
- name: Install Pods (iOS)
if: ${{ matrix.platform == 'iOS' }}
working-directory: ${{ env.APP_NAME }}/ios
run: bundle install && bundle exec pod install
- name: Install Fabric Pods (iOS)
if: ${{ matrix.react-native-architecture == 'Fabric' && matrix.platform == 'iOS' }}
working-directory: ${{ env.APP_NAME }}/ios
run: RCT_NEW_ARCH_ENABLED=1 bundle install && bundle exec pod install
- name: Setup Fabric (Android)
if: ${{ matrix.react-native-architecture == 'Fabric' && matrix.platform == 'Android' }}
working-directory: ${{ env.APP_NAME }}/android
run: sed -i 's/newArchEnabled=false/newArchEnabled=true/' gradle.properties
- name: Build app (iOS)
if: ${{ matrix.platform == 'iOS' }}
working-directory: ${{ env.APP_NAME }}
Expand Down
19 changes: 5 additions & 14 deletions .github/workflows/reanimated-compatibility-check-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,16 @@ jobs:
# Update it when dropping support for RN versions.
react-native:
[
{ version: '0.74', architecture: 'Paper' },
{ version: '0.74', architecture: 'Fabric' },
{ version: '0.75', architecture: 'Paper' },
{ version: '0.75', architecture: 'Fabric' },
{ version: '0.76', architecture: 'Paper' },
{ version: '0.76', architecture: 'Fabric' },
{ version: '0.77', architecture: 'Paper' },
{ version: '0.77', architecture: 'Fabric' },
{ version: '0.74' },
{ version: '0.75' },
{ version: '0.76' },
{ version: '0.77' },
]
fail-fast: false
env:
APP_NAME: app
RCT_NEW_ARCH_ENABLED: ${{ matrix.react-native.architecture == 'Fabric' && '1' || '0' }}
concurrency:
group: react-native-nightly-reanimated-build-check-${{ matrix.react-native.version}}-${{matrix.platform}}-${{matrix.react-native.architecture}}-${{ matrix.mode }}-${{ github.ref }}
group: react-native-nightly-reanimated-build-check-${{ matrix.react-native.version}}-${{matrix.platform}}-${{ matrix.mode }}-${{ github.ref }}
cancel-in-progress: true
steps:
- name: Set up JDK 18
Expand Down Expand Up @@ -74,10 +69,6 @@ jobs:
if: ${{ matrix.platform == 'iOS' }}
working-directory: ${{ env.APP_NAME }}/ios
run: bundle install && bundle exec pod update
- name: Setup Fabric (Android)
if: ${{ matrix.platform == 'Android' && matrix.react-native.architecture == 'Fabric' }}
working-directory: ${{ env.APP_NAME }}/android
run: sed -i 's/newArchEnabled=false/newArchEnabled=true/' gradle.properties
- name: Build app (iOS)
if: ${{ matrix.platform == 'iOS' }}
working-directory: ${{ env.APP_NAME }}/ios
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,8 @@ jobs:
build:
if: github.repository == 'software-mansion/react-native-reanimated'
runs-on: macos-14
strategy:
matrix:
react-native-architecture: ['Paper', 'Fabric']
fail-fast: false
concurrency:
group: ios-static-framework-${{ matrix.react-native-architecture }}-${{ github.ref }}
group: ios-static-framework-${{ github.ref }}
cancel-in-progress: true
env:
APP_NAME: app
Expand All @@ -44,14 +40,9 @@ jobs:
- name: Install Reanimated
working-directory: ${{ env.APP_NAME }}
run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}"
- name: Install Paper Pods
if: ${{ matrix.react-native-architecture == 'Paper' }}
- name: Install Pods
working-directory: ${{env.APP_NAME}}/ios
run: export USE_FRAMEWORKS=static NO_FLIPPER=1 && bundle install && bundle exec pod install
- name: Install Fabric Pods
if: ${{ matrix.react-native-architecture == 'Fabric' }}
working-directory: ${{env.APP_NAME}}/ios
run: export USE_FRAMEWORKS=static NO_FLIPPER=1 RCT_NEW_ARCH_ENABLED=1 && bundle install && bundle exec pod update
run: export USE_FRAMEWORKS=static && bundle install && bundle exec pod update
- name: Build app
working-directory: ${{env.APP_NAME}}/ios
run: xcodebuild -workspace ${{env.APP_NAME}}.xcworkspace -scheme ${{env.APP_NAME}} -configuration Debug -destination 'generic/platform=iOS Simulator' build | xcpretty
2 changes: 2 additions & 0 deletions packages/react-native-worklets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@
"android",
"apple",
"Common",
"scripts",
"plugin",
"*.podspec",
"react-native.config.js",
"!apple/build",
Expand Down
Loading