Add Endpoint serverLogicSuccessPure and serverLogicErrorPure #3837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two methods to
Endpoint
to avoid boilerplatesserverLogicSuccessPure
- For cases where the result is always a pure success ( healthcheck, stream*, etc... )serverLogicErrorPure
- For cases where the result is always a pure failure* stream = when you build a streamed API the logic is
F[Either[E, Stream[...]]]
since the errors and the side effects will be handled by the stream you often have to write.serverLogicSuccess(i => myStream(i).pure[F])
. withserverLogicSuccessPure
you can avoid that small boiler plate when needed.I also wonder if it would be useful to add something like
serverStreamLogic
which is equals toserverLogicSuccessPure
but have the constraints that the output is a stream ( Idk if this is feasible ). The advantages in this case are just the readability and the clarity of the code