Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate opentelemetry tracing context from the received headers #4418

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

adamw
Copy link
Member

@adamw adamw commented Mar 13, 2025

No description provided.

`ThreadLocal`-based, which works with synchronous/direct-style environments, including ones leveraging Ox and virtual
threads. [[Future]]s are supported through instrumentation provided by the
[OpenTelemetry javaagent](https://opentelemetry.io/docs/zero-code/java/agent/). For functional effect systems, usually
a dedicated integration library is required.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @gaeljw

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adamw adamw merged commit af46341 into master Mar 13, 2025
33 checks passed
@adamw adamw deleted the otel-trace-propagate branch March 13, 2025 19:37
@max-peroch
Copy link

Hi @adamw, FYI 1.11.19 seems to break my otel integration, it worked great with 1.11.18 using CE 3.6.0-RC2 and Otel4s 0.12.0-RC3 though

@adamw
Copy link
Member Author

adamw commented Mar 15, 2025

@max-peroch I think I'll need some more details :) Which otel integration? Did you use this interceptor with cats-effect?

@max-peroch
Copy link

max-peroch commented Mar 17, 2025

That's fair haha, sorry! I'll open a ticket with a repro case 👍

Edit: #4430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants