Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out of bounds error on 50th RK filled #407

Closed
My1 opened this issue Mar 27, 2020 · 1 comment
Closed

out of bounds error on 50th RK filled #407

My1 opened this issue Mar 27, 2020 · 1 comment

Comments

@My1
Copy link
Contributor

My1 commented Mar 27, 2020

okay this is a weird one

precondition:
50th Residential slot filled (the th is no mistake, deleting earlier credentials doesnt seem to affect this)

trigger:
list credentials using solokeys/solo1-cli#71 or chrome

effect:

[CP] CP map has 2 elements
[CP] CP_pinProtocol
[CP] CP_subCommand
[CP] CP_cmdGetKeyAgreement
[CP] CP map has 4 elements
[CP] CP_pinProtocol
[CP] CP_subCommand
[CP] CP_keyAgreement
[CP] CP_pinHashEnc
[CP] CP_cmdGetPinToken
[MC] RP Begin @0.  1 total.
[CRED_MGMT] Get RP 0
[ERR] src/device.c:817: Out of bounds reading index 50 for rk
[ERR] src/device.c:817: Out of bounds reading index 50 for rk
[ERR] src/device.c:817: Out of bounds reading index 51 for rk
[ERR] src/device.c:817: Out of bounds reading index 51 for rk
[ERR] src/device.c:817: Out of bounds reading index 52 for rk
[ERR] src/device.c:817: Out of bounds reading index 52 for rk
[ERR] src/device.c:817: Out of bounds reading index 53 for rk
[ERR] src/device.c:817: Out of bounds reading index 53 for rk

and so on, basically lists every number twice and just increases in rapid succession. device becomes unresponsive until powercycle. (can be seen especially well on somu as it no longer turns blue upon touch)

tested using 4.0.0 with button skip provided by @conorpp
if the first credential (index 0) is deleted begin @0 as well as Get RP 0 become 1 instead. otherwise the same.

conorpp added a commit that referenced this issue Mar 28, 2020
conorpp added a commit that referenced this issue Mar 28, 2020
@conorpp
Copy link
Member

conorpp commented Mar 31, 2020

This should be fixed now

@conorpp conorpp closed this as completed Mar 31, 2020
merlokk pushed a commit to merlokk/solo that referenced this issue Jun 14, 2020
merlokk pushed a commit to merlokk/solo that referenced this issue Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants