Optimize counter initialization #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
keboliu
approved these changes
Dec 6, 2024
Signed-off-by: Stephen Sun <[email protected]>
|
/azp run |
|
No pipelines are associated with this pull request. |
|
Supplied benchmark data on the latest image (without vendor SAI mutex on counter polling APIs) |
kcudnik
approved these changes
Jan 10, 2025
|
should i marge this ? |
Yes, please. Thank you. |
This was referenced Feb 13, 2025
kcudnik
pushed a commit
to sonic-net/sonic-sairedis
that referenced
this pull request
Feb 19, 2025
…r poll calls and communication between swss/sairedis (#1527) Optimize counter initialization by reducing the number of bulk counter poll calls and communication between swss(orchagent)/sairedis(syncd) during initialization. Originally, orchagent notifies syncd to initialize the counter using an extended sairedis call SAI_REDIS_SWITCH_ATTR_FLEX_COUNTER for each SAI object with the object ID as the key, which means the number of the extended sairedis calls is identical as the number of objects. It takes time to finish all the extended sairedis calls. Now, for counter groups that have many objects (e.g., port, PG, queues, etc), orchagent notifies syncd to initialize the counter using a single extend sairedis call with many objects' ID as the key (format: <key1>,<key2>,...<keyn>). So, it takes much less time to initialize the counters because fewer extend sairedis calls are required. Details: In sairedis, the bulk counter is supported for all counter groups except Buffer Pool Counter and DASH ENI counter. In swss, bulk counter for the following counter groups priority group watermark priority group drop queue watermark queue stat PFC watchdog HLD sonic-net/SONiC#1862
mssonicbld
added a commit
to mssonicbld/sonic-sairedis.msft
that referenced
this pull request
Feb 28, 2025
…r poll calls and communication between swss/sairedis Optimize counter initialization by reducing the number of bulk counter poll calls and communication between swss(orchagent)/sairedis(syncd) during initialization. Originally, `orchagent` notifies `syncd` to initialize the counter using an extended sairedis call `SAI_REDIS_SWITCH_ATTR_FLEX_COUNTER` for each SAI object with the object ID as the key, which means the number of the extended sairedis calls is identical as the number of objects. It takes time to finish all the extended sairedis calls. Now, for counter groups that have many objects (e.g., port, PG, queues, etc), `orchagent` notifies `syncd` to initialize the counter using a single extend sairedis call with many objects' ID as the key (format: `<key1>,<key2>,...<keyn>`). So, it takes much less time to initialize the counters because fewer extend sairedis calls are required. Details: - In sairedis, the bulk counter is supported for all counter groups except `Buffer Pool Counter` and `DASH ENI counter`. - In swss, bulk counter for the following counter groups - priority group watermark - priority group drop - queue watermark - queue stat - PFC watchdog HLD sonic-net/SONiC#1862
mssonicbld
added a commit
to Azure/sonic-sairedis.msft
that referenced
this pull request
Feb 28, 2025
…r poll calls and communication between swss/sairedis (#25) Optimize counter initialization by reducing the number of bulk counter poll calls and communication between swss(orchagent)/sairedis(syncd) during initialization. Originally, `orchagent` notifies `syncd` to initialize the counter using an extended sairedis call `SAI_REDIS_SWITCH_ATTR_FLEX_COUNTER` for each SAI object with the object ID as the key, which means the number of the extended sairedis calls is identical as the number of objects. It takes time to finish all the extended sairedis calls. Now, for counter groups that have many objects (e.g., port, PG, queues, etc), `orchagent` notifies `syncd` to initialize the counter using a single extend sairedis call with many objects' ID as the key (format: `<key1>,<key2>,...<keyn>`). So, it takes much less time to initialize the counters because fewer extend sairedis calls are required. Details: - In sairedis, the bulk counter is supported for all counter groups except `Buffer Pool Counter` and `DASH ENI counter`. - In swss, bulk counter for the following counter groups - priority group watermark - priority group drop - queue watermark - queue stat - PFC watchdog HLD sonic-net/SONiC#1862
mssonicbld
added a commit
to mssonicbld/sonic-swss.msft
that referenced
this pull request
Mar 4, 2025
…r poll calls and communication between swss/sairedis <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** Optimize counter initialization by reducing the number of bulk counter poll calls and communication between swss(orchagent)/sairedis(syncd) during initialization. Originally, `orchagent` notifies `syncd` to initialize the counter using an extended sairedis call `SAI_REDIS_SWITCH_ATTR_FLEX_COUNTER` for each SAI object with the object ID as the key, which means the number of the extended sairedis calls is identical as the number of objects. It takes time to finish all the extended sairedis calls. Now, for counter groups that have many objects (e.g., port, PG, queues, etc), `orchagent` notifies `syncd` to initialize the counter using a single extend sairedis call with many objects' ID as the key (format: `<key1>,<key2>,...<keyn>`). So, it takes much less time to initialize the counters because fewer extend sairedis calls are required. HLD sonic-net/SONiC#1862 Depends on sonic-net/sonic-sairedis#1527 **Why I did it** **How I verified it** Unit test (mock test) and regression. **Details if related** - In sairedis, the bulk counter is supported for all counter groups except `Buffer Pool Counter` and `DASH ENI counter`. - In swss, bulk counter for the following counter groups - priority group watermark - priority group drop - queue watermark - queue stat - PFC watchdog - WRED/ECN counter
mssonicbld
added a commit
to Azure/sonic-swss.msft
that referenced
this pull request
Mar 4, 2025
…r poll calls and communication between swss/sairedis (#49) <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** Optimize counter initialization by reducing the number of bulk counter poll calls and communication between swss(orchagent)/sairedis(syncd) during initialization. Originally, `orchagent` notifies `syncd` to initialize the counter using an extended sairedis call `SAI_REDIS_SWITCH_ATTR_FLEX_COUNTER` for each SAI object with the object ID as the key, which means the number of the extended sairedis calls is identical as the number of objects. It takes time to finish all the extended sairedis calls. Now, for counter groups that have many objects (e.g., port, PG, queues, etc), `orchagent` notifies `syncd` to initialize the counter using a single extend sairedis call with many objects' ID as the key (format: `<key1>,<key2>,...<keyn>`). So, it takes much less time to initialize the counters because fewer extend sairedis calls are required. HLD sonic-net/SONiC#1862 Depends on sonic-net/sonic-sairedis#1527 **Why I did it** **How I verified it** Unit test (mock test) and regression. **Details if related** - In sairedis, the bulk counter is supported for all counter groups except `Buffer Pool Counter` and `DASH ENI counter`. - In swss, bulk counter for the following counter groups - priority group watermark - priority group drop - queue watermark - queue stat - PFC watchdog - WRED/ECN counter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize counter initialization by reducing the number of bulk counter poll calls during initialization.
Implementation PRs
Signed-off-by: Stephen Sun [email protected]