[Clock] Add timezone config YANG model #14651
Conversation
|
|
|
@fastiuk Can you please update correct PR in the description? I believe it should be sonic-net/SONiC#1171 |
I did already. I didn't notice the issue at the beginning |
fastiuk
force-pushed
the
dev-clock-commands
branch
from
1b68d5e to
f512d4a
Compare
fastiuk
changed the title
fastiuk
force-pushed
the
dev-clock-commands
branch
from
f512d4a to
d1e1313
Compare
|
Rebased to resolve conflicts |
|
Ping here |
fastiuk
force-pushed
the
dev-clock-commands
branch
from
d1e1313 to
e457a3f
Compare
|
Rebased due to conflicts |
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
fastiuk
force-pushed
the
dev-clock-commands
branch
from
e457a3f to
60695c2
Compare
|
@yxieca I replaced |
| leaf timezone { | ||
| type stypes:timezone-name-type { | ||
| length 1..255; | ||
| } |
There was a problem hiding this comment.
Why not move length to sonic-types.yang?
There was a problem hiding this comment.
agreed. Others look good to me.
There was a problem hiding this comment.
timezone-name-type was copied from the Openconfig. I prefer to leave it unchanged there. So that is why I add the length definition here.
There was a problem hiding this comment.
Yes, we shouldn't allow empty timezones, as well as enormous long strings, like more than 255 characters long.
* Add the ability to configure timezone Signed-off-by: Yevhen Fastiuk <[email protected]> * Add YANG model for timezone Signed-off-by: Yevhen Fastiuk <[email protected]> * Add timezone reference Signed-off-by: Yevhen Fastiuk <[email protected]> --------- Signed-off-by: Yevhen Fastiuk <[email protected]>
hld #1219
closes #1171
depends-on #2793, #57
Why I did it
How I did it
init_cfg.jsonHow to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
Device metadata configuration
A picture of a cute animal (it is my cat Finn)