-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Clock] Add timezone config YANG model #14651
Conversation
@fastiuk Can you please update correct PR in the description? I believe it should be sonic-net/SONiC#1171 |
I did already. I didn't notice the issue at the beginning |
1b68d5e
to
f512d4a
Compare
f512d4a
to
d1e1313
Compare
Rebased to resolve conflicts |
Ping here |
d1e1313
to
e457a3f
Compare
Rebased due to conflicts |
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
e457a3f
to
60695c2
Compare
@yxieca I replaced |
leaf timezone { | ||
type stypes:timezone-name-type { | ||
length 1..255; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not move length to sonic-types.yang?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. Others look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timezone-name-type
was copied from the Openconfig. I prefer to leave it unchanged there. So that is why I add the length definition here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need length?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we shouldn't allow empty timezones, as well as enormous long strings, like more than 255 characters long.
* Add the ability to configure timezone Signed-off-by: Yevhen Fastiuk <[email protected]> * Add YANG model for timezone Signed-off-by: Yevhen Fastiuk <[email protected]> * Add timezone reference Signed-off-by: Yevhen Fastiuk <[email protected]> --------- Signed-off-by: Yevhen Fastiuk <[email protected]>
hld #1219
closes #1171
depends-on #2793, #57
Why I did it
How I did it
init_cfg.json
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
Device metadata configuration
A picture of a cute animal (it is my cat Finn)