libyang: upgrade to v3 step 3 -- port sonic-yang-mgmt #21716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qiluo-msft @ganglyu this is the next PR in the series of libyang3 porting... |
bradh352
force-pushed
the
bradh352/libyang3-pr2
branch
from
4ba074f to
cb482c1
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
changed the title
bradh352
force-pushed
the
bradh352/libyang3-pr2
branch
from
cb482c1 to
cf56243
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 12, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 12, 2025
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 13, 2025
bradh352
force-pushed
the
bradh352/libyang3-pr2
branch
from
491a041 to
ef2790d
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 13, 2025
bradh352
force-pushed
the
bradh352/libyang3-pr2
branch
from
ef2790d to
5f82fd2
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
force-pushed
the
bradh352/libyang3-pr2
branch
from
5f82fd2 to
2a4d521
Compare
A few things of note here:
* The paths generated by libyang3 no longer have the prefix before
each node, so these changes are valid that strip those.
See https://netopeer.liberouter.org/doc/libyang/master/html/howto_x_path.html:
```
As for the format of any prefixes, the standardized JSON (RFC 7951) was used.
Summarized, xpath follows these conventions:
...
* nodes always inherit their module (prefix) from their parent node so whenever
a node is from a different module than its parent, it MUST have a prefix
* nodes from the same module as their parent MUST NOT have a prefix
...
```
* The schema dependencies have been enhanced to support references within
unions so more paths are returned now.
…s set it to LY_LOSTORE by default (LY_LOLOG) is disabled which is what this was intending
bradh352
force-pushed
the
bradh352/libyang3-pr2
branch
from
ccea46c to
394e0eb
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 6, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 6, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 6, 2025
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 7, 2025
bradh352
force-pushed
the
bradh352/libyang3-pr2
branch
from
fb12c4e to
14dcadd
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
force-pushed
the
bradh352/libyang3-pr2
branch
from
14dcadd to
4bafb2b
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
force-pushed
the
bradh352/libyang3-pr2
branch
from
4bafb2b to
a329bb4
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
GCU calls this over and over. We don't want a whole tree reversal each time, cache!
bradh352
force-pushed
the
bradh352/libyang3-pr2
branch
from
a329bb4 to
df14eb9
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
force-pushed
the
bradh352/libyang3-pr2
branch
from
ce4f096 to
eb02b43
Compare
|
/azp run Azure.sonic-buildimage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
libyang3 porting.
Port of sonic-yang-mgmt
NOTE: this PR actually includes (as a squashed commits) PR #21679, #21719. Please review the individual commits (skipping the squashed commit) otherwise this may seem too large/confusing.
Depends PR #21679, #21719
Work item tracking
How I did it
How to verify it
All PRs listed on #21679 must be merged into a local build tree in order to test due to cross-repository dependencies.
It is expected the CI/CD system to FAIL with this PR due to cross dependencies, so do not treat such failures as a reason to not review these changes.
Which release branch to backport (provide reason below if selected)
None
Tested branch (Please provide the tested image version)
master as of 20250212
Description for the changelog
libyang: upgrade to v3 step 2 -- port sonic-yang-mgmt
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Brad House (@bradh352)