Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[swss.sh] cleanup LAG entries in STATE DB for non-warm boot #3114

Merged
merged 1 commit into from
Jul 9, 2019
Merged

[swss.sh] cleanup LAG entries in STATE DB for non-warm boot #3114

merged 1 commit into from
Jul 9, 2019

Conversation

stepanblyschak
Copy link
Collaborator

Signed-off-by: Stepan Blyschak [email protected]

- What I did

cleanup LAG entries in STATE DB

- How I did it
cleanup LAG entries in STATE DB

- How to verify it

This bug caused PortChannel lose IP configuration after config reload.
There is a race between intfsmgr and PortChannel creation, since LAG_TABLE will have state: OK infsmgrd will set IP, then PortChannel interface gets recreated by teamd as a result without IP configuration

- Description for the changelog
[swss.sh] cleanup LAG entries in STATE DB

- A picture of a cute animal (not mandatory but encouraged)

@stepanblyschak
Copy link
Collaborator Author

This is causing failures in regression tests which do config reload.
Can we merge as is and later rewrite this "cleanup_tables" line because the list becomes bigger and bigger causing bugs like #2932 ?

@lguohan
Copy link
Collaborator

lguohan commented Jul 3, 2019

why is this not needed in 201811 branch?

@stepanblyschak
Copy link
Collaborator Author

@lguohan I haven't seen PortChannel loses IP because of race between intfsmgrd and teamd on 201811, but I think it can be reproduced there as well if perform many iterations of config reload.
However not cleaning up state DB LAG entry is not correct IMO as restarted daemons may think interface is ready when it is not.

@stepanblyschak
Copy link
Collaborator Author

Retest vs please

@stepanblyschak stepanblyschak mentioned this pull request Jul 5, 2019
Closed
@liat-grozovik
Copy link
Collaborator

@lguohan can you please check why vs is failing? i see it fails of network unreachable.

@liat-grozovik
Copy link
Collaborator

Retest vs please

@stcheng stcheng merged commit 59117d2 into sonic-net:master Jul 9, 2019
@lguohan lguohan changed the title [swss.sh] cleanup LAG entries in STATE DB [swss.sh] cleanup LAG entries in STATE DB for non-warm boot Jul 9, 2019
yxieca pushed a commit that referenced this pull request Jul 10, 2019
@stepanblyschak @yxieca
[swss.sh]: Cleanup LAG entries in STATE DB (#3114)
4b5abd0 
Signed-off-by: Stepan Blyschak <[email protected]>
@habeebmohammed habeebmohammed mentioned this pull request Jul 18, 2019
Closed
@stepanblyschak stepanblyschak deleted the fix_portchannel_cleanup branch September 23, 2022 13:31
mssonicbld added a commit that referenced this pull request Feb 6, 2024
@mssonicbld
[submodule] Update submodule sonic-utilities to the latest HEAD autom…
3d9cf77 
…atically (#18049)

#### Why I did it
src/sonic-utilities
```
* b5487357 - (HEAD -> master, origin/master, origin/HEAD) [route_check.py] account static routes in route_check.py (#3120) (9 hours ago) [Stepan Blyshchak]
* 64e1f9f4 - [Mellanox buffer migrator] Do not touch the buffer model on generic SKUs if the buffer configuration is empty (#3114) (19 hours ago) [Stephen Sun]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Feb 19, 2024
@mssonicbld
[submodule] Update submodule sonic-utilities to the latest HEAD autom…
5ec5da7 
…atically (#18128)

#### Why I did it
src/sonic-utilities
```
* c711b061 - (HEAD -> 202311, origin/202311) [Mellanox buffer migrator] Do not touch the buffer model on generic SKUs if the buffer configuration is empty (#3114) (2 days ago) [Stephen Sun]
```
#### How I did it
#### How to verify it
#### Description for the changelog
sonic-otn pushed a commit to Weitang-Zheng/sonic-buildimage that referenced this pull request Mar 11, 2024
@mssonicbld @sonic-otn
[submodule] Update submodule sonic-utilities to the latest HEAD autom…
ec82875 
…atically (sonic-net#18049)

#### Why I did it
src/sonic-utilities
```
* b5487357 - (HEAD -> master, origin/master, origin/HEAD) [route_check.py] account static routes in route_check.py (sonic-net#3120) (9 hours ago) [Stepan Blyshchak]
* 64e1f9f4 - [Mellanox buffer migrator] Do not touch the buffer model on generic SKUs if the buffer configuration is empty (sonic-net#3114) (19 hours ago) [Stephen Sun]
```
#### How I did it
#### How to verify it
#### Description for the changelog
saksarav-nokia pushed a commit to saksarav-nokia/sonic-buildimage that referenced this pull request Mar 12, 2024
@mssonicbld @saksarav-nokia
[submodule] Update submodule sonic-utilities to the latest HEAD autom…
ced6fee 
…atically (sonic-net#18049)

#### Why I did it
src/sonic-utilities
```
* b5487357 - (HEAD -> master, origin/master, origin/HEAD) [route_check.py] account static routes in route_check.py (sonic-net#3120) (9 hours ago) [Stepan Blyshchak]
* 64e1f9f4 - [Mellanox buffer migrator] Do not touch the buffer model on generic SKUs if the buffer configuration is empty (sonic-net#3114) (19 hours ago) [Stephen Sun]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Apr 19, 2024
@mssonicbld
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
e3d9fbe 
…lly (#18334)

#### Why I did it
src/sonic-swss
```
* 9e183a65 - (HEAD -> master, origin/master, origin/HEAD) Add bookworm build to the PR checkers (#3114) (2 days ago) [Saikrishna Arcot]
* ec463953 - [twamporch] Explicitly initialize local variable (#3115) (2 days ago) [xiaodong hu]
* 19410232 - Add force option for fabric port unisolate command (#3089) (7 days ago) [jfeng-arista]
* 774973d9 - [dash] fix ENI admin state update (#3081) (8 days ago) [Yakiv Huryk]
* 56ba6de3 - [p4orch] Clang format change. (#3096) (10 days ago) [mint570]
* f6dd9caa - Introduce a new role for DPU-NPU Interconnect (10 days ago) [Vivek]
* 0f707757 - [portsorch] Handle TRANSCEIVER_INFO table on warm boot (#3087) (10 days ago) [Stepan Blyshchak]
* cbc263a1 - [EVPN]Fix fpmsyncd crash when EVPN type5 is received with bgp fib suppression enabled (#3101) (13 days ago) [Sudharsan Dhamal Gopalarathnam]
* 4af61167 - Fix oper FEC retrieval after warmboot (#3100) (13 days ago) [Sudharsan Dhamal Gopalarathnam]
* 2a586154 - [Fdbsyncd] Adding extern_learn flag with fdb entry so Kernel doesn't age out (#2985) (2 weeks ago) [KISHORE KUNAL]
* 465399e9 - T2-VOQ-VS: Fix iBGP bringup issue (#3053) (2 weeks ago) [Deepak Singhal]
* dc9eae87 - Clang format change. (#3080) (2 weeks ago) [mint570]
* 95a74750 - [orchagent] TWAMP Light orchagent implementation (#2927) (2 weeks ago) [xiaodong hu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stcheng stcheng stcheng approved these changes

@prsunny prsunny prsunny approved these changes

@andriymoroz-mlnx andriymoroz-mlnx andriymoroz-mlnx approved these changes

@mykolaf mykolaf mykolaf approved these changes

Assignees
No one assigned
Labels
Bug 🐛 Included in 201811 Branch Request for 201811 Branch :shipit: Request for 201904 Branch 🏂
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@stepanblyschak @lguohan @liat-grozovik @stcheng @prsunny @andriymoroz-mlnx @mykolaf @yxieca