Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swi-tools in buster Dockerfile #6414

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

Staphylo
Copy link
Collaborator

- Why I did it

This is part of the python2 to python3 migration effort.

- How I did it

Fixed swi-tools code to work with python3
Updated the version of swi-tools downloaded by the sonic-slave-buster/Dockerfile.j2
Other Dockerfiles still use the python2 version, though swi-tools is not used within the stretch builder.

- How to verify it

Build an image with SONIC_ENABLE_IMAGE_SIGNATURE = y and verify that build passes.
Install the image on a secureboot enabled product to verify that it works.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

It is pretty much a harmless change that push python2 to python3 conversion closer to the finish line.

- Description for the changelog

Update the swi-tools version used by buster Dockerfile

Use the python3 version by default
@Staphylo Staphylo marked this pull request as ready for review January 12, 2021 23:46
@jleveque jleveque merged commit 68e9b83 into sonic-net:master Jan 13, 2021
lguohan pushed a commit that referenced this pull request Jan 15, 2021
Fixed swi-tools code to work with `python3`
Updated the version of swi-tools downloaded by the `sonic-slave-buster/Dockerfile.j2`
Other Dockerfiles still use the `python2` version, though swi-tools is not used within the stretch builder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants