Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Add patches for i2c API #162

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

volodymyrsamotiy
Copy link
Collaborator

@volodymyrsamotiy volodymyrsamotiy commented Oct 6, 2020

From 6360f7272a370eee26118d46d963bb91ea36dfa2 Mon Sep 17 00:00:00 2001
From: Vadim Pasternak [email protected]
Date: Tue, 29 Sep 2020 08:58:57 +0300
Subject: [PATCH backport v4.19 0/8]

Patchset contians backport of the below commits:
commit 3dcfe179570550c888ecfcd3d443d4de90a2d855
commit 3029a693beda5bff599feccc3beb9df1e141c786
commit 6a986993e43f176e07c28df560b1cfc3e9b80505
commit 95b75cbd1bc57ec5898517a3fb2f7621f16b26cd
commit f43d9d9b4eb869b1c1513ce8b931389b64b92db1
commit 27758c801663d17eafcd4e45179e7294a9c290b8

From commit 3dcfe179570550c888ecfcd3d443d4de90a2d855 backported only
setting of I2C bus frequnecy, other code from this commit has been
applied in older commits.
commit.

Patchset contians 'mlxsw: i2c: Add device info log', adding info log
to probe() routine to report firmware setting in 'dmesg'.
This is not upstream commit, but this code has been exist in Sonic from
day one and used for debug purpose.

Vadim Pasternak (7):
mlxsw: i2c: Fix comment misspelling
mlxsw: i2c: Modify input parameter name in initialization API
mlxsw: i2c: Extend input parameters list of command API
mlxsw: i2c: Extend initialization by querying resources data
mlxsw: i2c: Extend initialization with querying firmware info
mlxsw: i2c: Allow flexible setting of I2C transactions size
mlxsw: core: Set different thermal polling time based on bus frequency capability

drivers/net/ethernet/mellanox/mlxsw/core_thermal.c | 6 +-
drivers/net/ethernet/mellanox/mlxsw/i2c.c | 212 +++++++++++++++++----
2 files changed, 178 insertions(+), 40 deletions(-)

--
2.11.0

@volodymyrsamotiy volodymyrsamotiy changed the title Add patches for i2c API [Mellanox] Add patches for i2c API Oct 6, 2020
@lguohan
Copy link
Contributor

lguohan commented Oct 6, 2020

what is this commit id? 9bbd7efbc055b31b0e836936da94791c8890af4b

I cannot find in the https://github.com/torvalds/linux

@keboliu
Copy link
Collaborator

keboliu commented Oct 12, 2020

what is this commit id? 9bbd7efbc055b31b0e836936da94791c8890af4b

I cannot find in the https://github.com/torvalds/linux

Hi @lguohan
as described in this PR description:

Patchset contians 'mlxsw: i2c: Add device info log', adding info log
to probe() routine to report firmware setting in 'dmesg'.
This is not upstream commit, but this code has been exist in Sonic from
day one and used for debug purposes.

this log is very useful for the issue debug, so we want to keep it although it's not in the upstream, of course, need your approval.

@liat-grozovik
Copy link
Collaborator

@volodymyrsamotiy lets please divide the patch to 2: 1 fully aligned to upstream code, 1 with the extra patch which is not upstream and for debug purposes.

* Fix review comments

Signed-off-by: Volodymyr Samotiy <[email protected]>
@liat-grozovik
Copy link
Collaborator

@lguohan now it should be aligned to only upstream code. Please check

@liat-grozovik
Copy link
Collaborator

@lguohan kindly please check if this can be merged. we have broken image on master and this fix is a must.

@lguohan
Copy link
Contributor

lguohan commented Oct 30, 2020

@liat-grozovik , i cannot find these commit id in the linux kernel tree.

Patchset contians backport of the below commits:
commit 3dcfe179570550c888ecfcd3d443d4de90a2d855
commit 3029a693beda5bff599feccc3beb9df1e141c786
commit 6a986993e43f176e07c28df560b1cfc3e9b80505
commit 95b75cbd1bc57ec5898517a3fb2f7621f16b26cd
commit f43d9d9b4eb869b1c1513ce8b931389b64b92db1
commit 27758c801663d17eafcd4e45179e7294a9c290b8

https://github.com/torvalds/linux/search?q=3dcfe179570550c888ecfcd3d443d4de90a2d855

can you please help tell me where to find the upstream commit id?

@keboliu
Copy link
Collaborator

keboliu commented Nov 2, 2020

@liat-grozovik , i cannot find these commit id in the linux kernel tree.

Patchset contians backport of the below commits:
commit 3dcfe179570550c888ecfcd3d443d4de90a2d855
commit 3029a693beda5bff599feccc3beb9df1e141c786
commit 6a986993e43f176e07c28df560b1cfc3e9b80505
commit 95b75cbd1bc57ec5898517a3fb2f7621f16b26cd
commit f43d9d9b4eb869b1c1513ce8b931389b64b92db1
commit 27758c801663d17eafcd4e45179e7294a9c290b8

https://github.com/torvalds/linux/search?q=3dcfe179570550c888ecfcd3d443d4de90a2d855

can you please help tell me where to find the upstream commit id?

@lguohan I am not sure why the search is not working, but the commit hash is correct, I manually checked:

mlxsw: i2c: Fix comment misspelling 27758c801663d17eafcd4e45179e7294a9c290b8 torvalds/linux@27758c8
mlxsw: i2c: Modify input parameter name in initialization API f43d9d9b4eb869b1c1513ce8b931389b64b92db1 torvalds/linux@f43d9d9
mlxsw: i2c: Extend input parameters list of command API 95b75cbd1bc57ec5898517a3fb2f7621f16b26cd torvalds/linux@95b75cb
mlxsw: i2c: Extend initialization by querying resources data 6a986993e43f176e07c28df560b1cfc3e9b80505 torvalds/linux@6a98699
mlxsw: i2c: Extend initialization with querying firmware info 9bbd7efbc055b31b0e836936da94791c8890af4b torvalds/linux@9bbd7ef
mlxsw: i2c: Allow flexible setting of I2C transactions size 3029a693beda5bff599feccc3beb9df1e141c786 torvalds/linux@3029a69
mlxsw: core: Set different thermal polling time based on bus frequency capability 3dcfe179570550c888ecfcd3d443d4de90a2d855 torvalds/linux@3dcfe17

@liat-grozovik
Copy link
Collaborator

@lguohan anything else is missing?

@lguohan
Copy link
Contributor

lguohan commented Nov 4, 2020

@liat-grozovik , can you check this pr? after i merged the other one, it seems there is some patch issue on this.

@lguohan
Copy link
Contributor

lguohan commented Nov 5, 2020

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants