Add t1-smartswitch topo support #14595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r12f
reviewed
Sep 16, 2024
r12f
reviewed
Sep 16, 2024
zjswhhh
changed the title
zjswhhh
changed the title
This reverts commit d6c12f7.
Description of PR Summary: Fixes # (issue) There has been an issue that missing exit in the FRR template that caused nht config is missed in the FRR config when vrf is configurated. After fixing the issue in sonic-net/sonic-buildimage#19587, add a new case to verify the 'ip nht resolve-via-default' should be present in FRR config whether vrf is configurated.
…net#15457) What is the motivation for this PR? Currently we are using conditional mark to add marker, then use pytest hook to redirect testutils.verify function to a function always return True to skip traffic test. With this change, the skip_traffic_test fixture is no longer needed in test cases, streamlining the test code and improving clarity. How did you do it? Remove skip_traffic_test fixture in sub_port_interfaces tests How did you verify/test it?
What is the motivation for this PR? Currently we are using conditional mark to add marker, then use pytest hook to redirect testutils.verify function to a function always return True to skip traffic test. With this change, the skip_traffic_test fixture is no longer needed in test cases, streamlining the test code and improving clarity. How did you do it? Remove skip_traffic_test fixture in ip tests How did you verify/test it?
sonic-net#15497) * enhance elastictest template, use bash script instead of azcli task, improve and fix azlogin and get token when requesting APIs * Directly specify the value of MGMT_BRANCH as master. Because dynamic assignment does not take effect immediately for the conditional statement of pipeline yaml, the expected value of MGMT_BRANCH cannot be obtained, and the locally updated testplan.py cannot be used. Signed-off-by: Chun'ang Li <[email protected]>
…ken issu…" (sonic-net#15502) This reverts commit 9b81013.
…t#15017) * skip route_flow_counter TCs on 8122 platforms * correcting conditional mark sort for test_route_flow_counter.py
* Fix replace ingress_lossless_pool * Add log * Fix log message.
|
Hi @wangxin -can you please help review? |
|
Is this topology used exclusively for KVM? For t1, we have various topologies such as t1-4-lag, t1-8-lag, etc. Which 11 topology is supported by this t1-smartswitch? |
Hi @ganglyu - this is currently supporting virtual testbed only. And lag is not supported by sonic-vpp (the kvm image). Physical testbed setup is in progress, and this is actually a good question that whether we should distinguish smartSwitch T1s with other T1 topo. We can discuss offline, but it might be out of scope of this PR. |
ganglyu
approved these changes
Dec 3, 2024
|
Hi @yxieca - can you help merge please? |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
This PR is to add t1-smartswitch support.
start_dpu_vmto create sonic-vs neighbor to mimic DPUsvm_topologyto bind DPUs interfaces to the bridges tooupdateannouce_routemodules to create exabgp processes on PTF for DPU neighbors too. Refer testbed routing for details.topo_factsandconfig_sonic_basedon_testbedmodules to update gen-mg logicssign-off: Jing Zhang [email protected]
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Deployed a
t1-smartswitchtestbed on my dev host.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation