-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test_bfd_multihop] add missing import of fixture #6382
[test_bfd_multihop] add missing import of fixture #6382
Conversation
Signed-off-by: Anton <[email protected]>
@siqbal1986 FYI |
This pull request introduces 1 alert when merging 848d15c into 9074e57 - view on LGTM.com new alerts:
|
/azp run |
Commenter does not have sufficient privileges for PR 6382 in repo sonic-net/sonic-mgmt |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
Signed-off-by: Anton <[email protected]>
Signed-off-by: Anton <[email protected]>
Signed-off-by: Anton [email protected]
Description of PR
Summary:
In PR #6032 mistake was introduced.
No import for the fixture.
As a result, the bfd_multihop test failed with error:
@pytest.mark.parametrize('ipv6', [False, True], ids=['ipv4', 'ipv6'])
def test_bfd_multihop(request, rand_selected_dut, ptfhost, tbinfo, toggle_all_simulator_ports_to_rand_selected_tor_m, ipv6):
E fixture 'toggle_all_simulator_ports_to_rand_selected_tor_m' not found
Added missed import of fixture.
Type of change
Back port request
Approach
What is the motivation for this PR?
Stabilize the test
How did you do it?
Added missed import of fixture.
How did you verify/test it?
Test executed and passed
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation