Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]: Update README.md #1122

Merged
merged 7 commits into from
Oct 4, 2022
Merged

[doc]: Update README.md #1122

merged 7 commits into from
Oct 4, 2022

Conversation

mdanish-kh
Copy link
Contributor

What I did

  • Fixed build URL and added Azure build URLs for each branch.
  • Update old URLs
  • General typo/grammar fix

@mdanish-kh
Copy link
Contributor Author

@kcudnik Can you please review?

kcudnik
kcudnik previously approved these changes Sep 12, 2022
@kcudnik
Copy link
Collaborator

kcudnik commented Sep 13, 2022

not sure why those builds fail, it's just readme file

@mdanish-kh
Copy link
Contributor Author

/AzurePipelines run Azure.sonic-sairedis

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 1122 in repo sonic-net/sonic-sairedis

@mdanish-kh mdanish-kh closed this Sep 13, 2022
@mdanish-kh mdanish-kh reopened this Sep 13, 2022
@mdanish-kh
Copy link
Contributor Author

Closed and re-opened the PR to re-run the pipelines, but it is still failing.

@mdanish-kh mdanish-kh closed this Sep 13, 2022
@mdanish-kh mdanish-kh reopened this Sep 13, 2022
@mdanish-kh mdanish-kh closed this Sep 14, 2022
@mdanish-kh mdanish-kh reopened this Sep 14, 2022
@mdanish-kh
Copy link
Contributor Author

The unit tests are repeatedly failing.

@mdanish-kh mdanish-kh closed this Sep 15, 2022
@mdanish-kh mdanish-kh reopened this Sep 15, 2022
@mdanish-kh mdanish-kh closed this Sep 15, 2022
@mdanish-kh mdanish-kh reopened this Sep 15, 2022
@mdanish-kh mdanish-kh closed this Sep 16, 2022
@mdanish-kh mdanish-kh reopened this Sep 16, 2022
@mdanish-kh mdanish-kh closed this Sep 30, 2022
@mdanish-kh mdanish-kh reopened this Sep 30, 2022
@kcudnik
Copy link
Collaborator

kcudnik commented Oct 1, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdanish-kh mdanish-kh closed this Oct 3, 2022
@mdanish-kh mdanish-kh reopened this Oct 3, 2022
@kcudnik
Copy link
Collaborator

kcudnik commented Oct 3, 2022

can you try to do a force push on this branch with empty commit to retriger all build ?
those should not fail at all when changing readme

@mdanish-kh
Copy link
Contributor Author

mdanish-kh commented Oct 3, 2022

can you try to do a force push on this branch with empty commit to retriger all build ? those should not fail at all when changing readme

@kcudnik I believe closing and re-opening the PR does the same. It re-runs the pipelines. I have been doing this for a few days, everytime the checks fail on the unittests in pipelines.

But I'll try to push an empty commit as well.

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 3, 2022

this is wired since other PR's are passing on tests, for example this one #1132 which was posted later

@mdanish-kh
Copy link
Contributor Author

mdanish-kh commented Oct 3, 2022

this is wired since other PR's are passing on tests, for example this one #1132 which was posted later

The same test i.e., Sairedis build (amd64) passes in my other PR in sonic-swss-common repo https://github.com/sonic-net/sonic-swss-common/pull/696/checks?check_run_id=8670553168, I don't know if some tests are different here in this repo's pipelines that do not make it pass here.

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 3, 2022

here:

../README.md:The SAI Redis provides a SAI redis service built on top of redis database. It contains two major components: 
ERROR: some files contain white spaces at the end of line, please fix
FAIL: checkwhitespace.sh

please fix whitespaces :)

@mdanish-kh
Copy link
Contributor Author

@kcudnik Thanks for pointing this out! Didn't realize a trailing white space causes issues in the pipelines, will keep this in mind in the future.

All checks have passed now. Could you please review again?

@kcudnik kcudnik merged commit 3fa8f34 into sonic-net:master Oct 4, 2022
@mdanish-kh mdanish-kh deleted the update-docs branch October 4, 2022 10:07
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants