[syncd] Add workaround for snoop SAI_PORT_ATTR_SPEED

syncd/Syncd.cpp

@@ -3044,6 +3044,24 @@ void Syncd::snoopGetResponse(
             continue;
         }
 
+        if (meta->objecttype == SAI_OBJECT_TYPE_PORT &&
+                meta->attrid == SAI_PORT_ATTR_SPEED)
+        {
+            /*
+             * This is workaround.  Skip port speed because of broadcom bug,
+             * after warm reboot SAI returns different speed then before warm
+             * reboot, which causes to generate SET operation on comparison
+             * logic and this SET operation fails.  There is no SET operation
+             * for speed generated by orchagent, since all values are snooped
+             * here.
+             *
+             * TODO: This should be removed when SAI will be fixed.
+             */
+
+            SWSS_LOG_INFO("skipping %s for %s", meta->attridname, strObjectId.c_str());
+            continue;
+        }
+
         /*
          * Put non readonly, and non oid attribute value to temp view.
          *

syncd/Syncd.h

@@ -347,7 +347,7 @@ namespace syncd
             void sendNotifyResponse(
                     _In_ sai_status_t status);
 
-        private: // snoop get response oids
+        public: // snoop get response oids
 
             void snoopGetResponse(
                     _In_ sai_object_type_t object_type,

unittest/syncd/Makefile.am

@@ -12,6 +12,7 @@ tests_SOURCES = main.cpp \
 				TestFlexCounter.cpp \
 				TestVirtualOidTranslator.cpp \
 				TestNotificationQueue.cpp \
+				TestSyncd.cpp \
 				TestVendorSai.cpp
 
 tests_CXXFLAGS = $(DBGFLAGS) $(AM_CXXFLAGS) $(CXXFLAGS_COMMON)

unittest/syncd/TestSyncd.cpp

@@ -0,0 +1,51 @@
+#include "Syncd.h"
+#include "VendorSai.h"
+#include "CommandLineOptions.h"
+#include "CommandLineOptionsParser.h"
+#include "SaiAttr.h"
+
+#include "swss/table.h"
+
+#include "meta/sai_serialize.h"
+
+#include <gtest/gtest.h>
+
+using namespace syncd;
+using namespace saimeta;
+
+TEST(Syncd, snoopGetResponse)
+{
+    auto commandLineOptions = CommandLineOptionsParser::parseCommandLine(0, NULL);
+
+    auto vendorSai = std::make_shared<VendorSai>();
+
+    auto syncd = std::make_shared<Syncd>(vendorSai, commandLineOptions, false);
+
+    sai_attribute_t attr;
+
+    attr.id = SAI_PORT_ATTR_SPEED;
+    attr.value.u32 = 25000;
+
+    syncd->snoopGetResponse(
+            SAI_OBJECT_TYPE_PORT,
+            sai_serialize_object_id(0x1000000000007L),
+            1,
+            &attr);
+
+    swss::DBConnector db("ASIC_DB", 0, true);
+
+    swss::Table t(&db, "ASIC_STATE");
+
+    sai_object_meta_key_t metaKey;
+
+    metaKey.objecttype = SAI_OBJECT_TYPE_PORT;
+    metaKey.objectkey.key.object_id = 0x1000000000007L;
+
+    std::string key = sai_serialize_object_meta_key(metaKey);
+
+    std::string value;
+
+    bool r = t.hget(key, "SAI_PORT_ATTR_SPEED", value);
+
+    EXPECT_FALSE(r);
+}