Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mellanox] Update Mellanoxs dump generation to include SDK dumps #833

Merged
merged 1 commit into from
May 30, 2021
Merged

[Mellanox] Update Mellanoxs dump generation to include SDK dumps #833

merged 1 commit into from
May 30, 2021

Conversation

DavidZagury
Copy link
Contributor

Create in Mellanox devices a folder from sai.profile key SAI_DUMP_STORE_PATH in the syncd docker to have it ready for SDK dumps

@DavidZagury DavidZagury mentioned this pull request May 25, 2021
Merged
4 tasks
@DavidZagury
Copy link
Contributor Author

6 Test have failed:

test_buffer_dynamic.py::TestBufferMgrDyn::test_changeCableLen FAILED
test_buffer_dynamic.py::TestBufferMgrDyn::test_MultipleLosslessPg FAILED
test_buffer_dynamic.py::TestBufferMgrDyn::test_headroomOverride FAILED
test_buffer_dynamic.py::TestBufferMgrDyn::test_mtuUpdate FAILED
test_buffer_dynamic.py::TestBufferMgrDyn::test_nonDefaultAlpha FAILED
test_buffer_dynamic.py::TestBufferMgrDyn::test_sharedHeadroomPool FAILED

The same 6 test also failed on: sonic-net/sonic-swss#1749

@liat-grozovik liat-grozovik requested a review from kcudnik May 30, 2021 06:55
@liat-grozovik
Copy link
Collaborator

@kcudnik could you please review?

liat-grozovik
liat-grozovik reviewed May 30, 2021
View reviewed changes
Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidZagury should you create the directory if the directory exists?

@kcudnik kcudnik merged commit 77d44f5 into sonic-net:master May 30, 2021
DavidZagury added a commit to DavidZagury/sonic-sairedis that referenced this pull request Jun 24, 2021
@DavidZagury
[Mellanox] Update mellanoxs dump generation to include SDK dumps (son…
5d9383d 
…ic-net#833)

Create in Mellanox devices a folder from sai.profile key SAI_DUMP_STORE_PATH in the syncd docker to have it ready for SDK dumps
qiluo-msft pushed a commit that referenced this pull request Jun 28, 2021
@DavidZagury @qiluo-msft
[Mellanox] Update mellanoxs dump generation to include SDK dumps (#833)
74b5808 
Create in Mellanox devices a folder from sai.profile key SAI_DUMP_STORE_PATH in the syncd docker to have it ready for SDK dumps
@liat-grozovik liat-grozovik mentioned this pull request Jun 29, 2021
Merged
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
@DavidZagury
[Mellanox] Update mellanoxs dump generation to include SDK dumps (son…
7c0d5af 
…ic-net#833)

Create in Mellanox devices a folder from sai.profile key SAI_DUMP_STORE_PATH in the syncd docker to have it ready for SDK dumps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@kcudnik kcudnik kcudnik approved these changes

Assignees
No one assigned
Labels
Enhancement Included in 202012 Branch Request for 202012 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidZagury @liat-grozovik @kcudnik @qiluo-msft