Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port speed set utility #174

Merged
merged 3 commits into from
Jan 16, 2018
Merged

Conversation

andriymoroz-mlnx
Copy link
Collaborator

- What I did
Added port speed configuration utility

- How I did it

- How to verify it
config interface speed Ethernet0 40000
See https://github.com/Azure/SONiC/wiki/Port-configuration-(speed)-utility for details

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

-->

@lguohan
Copy link
Contributor

lguohan commented Dec 20, 2017

@yxieca to review

@lguohan lguohan requested a review from yxieca December 20, 2017 18:01
@andriymoroz-mlnx andriymoroz-mlnx changed the title Buffer port speed Port speed set utility Dec 21, 2017
@stcheng
Copy link
Contributor

stcheng commented Jan 3, 2018

there is already a script called intfutil provided by @rodnymolina in the commit #158
this interface_stat is mostly the same with the intfutil
can we combine them together?

@rodnymolina could you also review this pull request?

Copy link
Contributor

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andriymoroz-mlnx
Copy link
Collaborator Author

@stcheng yes, you're right, interface_stat was renamed to intfutil. It should not be in this PR, merge issue...

Signed-off-by: Andriy Moroz <[email protected]>
@lguohan lguohan merged commit 17e0bf9 into sonic-net:master Jan 16, 2018
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
When using redis select, xcvrd is sleeping for 100 msec which appears
unnecessary after process all content of selectable objects.

signed-off-by: Tamer Ahmed <[email protected]>
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
… API's read size for read_eeprom (sonic-net#174)

This PR adds stub functions definition with details as to how firmware upgrade should be implemented by a Y cable vendor.
It also fixes the read_eeprom read size for vendor part number and vendor name retreival API's

Description
Added a stub functions definition with a doc string describing how it should be implemented
Added these API's stub functions for vendors to implement

def download_firmware(physical_port, fwfile)
def activate_firmware(physical_port)
def rollback_firmware(physical_port)

Motivation and Context
Firmware upgrade is a functionality that vendors need to implement, this PR adds the definition's
and a description of how the implementation of this firmware upgrade procedure API's should be implemented
by breaking down the firmware upgrade into above specified sub routines.

Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants