-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config] Add new command line to support mellanox sniffer #227
Conversation
modified: config/main.py new file: config/mlnx.py Signed-off-by: Kebo Liu [email protected]
do not pass ENV variable to syncd container by recreate the container instead manipulate the supervisord conf file to achieve it. Changes to be committed: modified: config/mlnx.py signed-off-by [email protected]
@cli.group() | ||
def platform(): | ||
"""Platform-related configuration tasks""" | ||
platform.add_command(mlnx.mlnx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this indentation work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stcheng It works well, please refer to line 163 in the same file to see how it load 'aaa' command group.
@lguohan @keboliu This commit is exposing mlnx specific cli in non mlnx platforms. Please fix. root@sonic:/# show platform ? Show platform-specific hardware info Options: Commands: Mellanox platform specific configuration tasks Options: Commands: |
@nikos-github thanks for reporting this issue, added it to todo list. |
Signed-off-by: Kebo Liu [email protected]
- What I did
Add new command line for Mellanox SDK sniffers
- How I did it
Add new cli group "platform" under "config" command.
"mlnx" subgroup of "platform" group is for Mellanox platform specific CLI
Add command "config platform mlnx sniffer sdk enable" to enable sdk sniffer
Add command "config platform mlnx sniffer sdk disable" to disable sdk sniffer
- How to verify it
On Mellanox platform can issue these command to enable and disable sdk sniffer.
- Previous command output (if the output of a command-line utility has changed)
please refer to design doc https://github.com/Azure/SONiC/wiki/Mellanox-SDK-and-PRM-Sniffer-Utility-CLI-Design-for-SONiC
- New command output (if the output of a command-line utility has changed)
please refer to design doc https://github.com/Azure/SONiC/wiki/Mellanox-SDK-and-PRM-Sniffer-Utility-CLI-Design-for-SONiC
This PR needs sonic-buildimage#1551 merged first.