remove os.system duo to security vulnerabilities #3720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-utilities |
|
thanks for fixing this vulnerable issue, pls follow up with test failure |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sunhorus
force-pushed
the
remove_os_system
branch
from
acbee44 to
b78ad5b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
All checks passed, and also unit tests |
maipbui
reviewed
Mar 7, 2025
| cmd="systemctl restart snmp" | ||
| os.system (cmd) | ||
| cmd = ["systemctl", "restart", "snmp"] | ||
| getstatusoutput_noshell(cmd) |
There was a problem hiding this comment.
you can replace os.system with subprocess.call, suggested in python doc https://docs.python.org/3/library/subprocess.html#replacing-os-system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
"os.system()" uses shell invocation to execute dangerous commands without a static string that can lead to command injection.
How I did it
pass list of strings to subprocess() - use shell=False instead.
How to verify it
pass UT
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)