Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove os.system duo to security vulnerabilities #3720

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunhorus
Copy link

What I did
"os.system()" uses shell invocation to execute dangerous commands without a static string that can lead to command injection.

How I did it
pass list of strings to subprocess() - use shell=False instead.

How to verify it
pass UT

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FengPan-Frank
Copy link
Contributor

/azpw run Azure.sonic-utilities

@FengPan-Frank
Copy link
Contributor

thanks for fixing this vulnerable issue, pls follow up with test failure

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sunhorus
Copy link
Author

sunhorus commented Mar 1, 2025

All checks passed, and also unit tests

Copy link
Contributor

@FengPan-Frank FengPan-Frank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd="systemctl restart snmp"
os.system (cmd)
cmd = ["systemctl", "restart", "snmp"]
getstatusoutput_noshell(cmd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getstatusoutput_noshell(cmd)

you can replace os.system with subprocess.call, suggested in python doc https://docs.python.org/3/library/subprocess.html#replacing-os-system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants