Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export leaderboard result #1102

Merged
merged 41 commits into from
Apr 6, 2024
Merged

Export leaderboard result #1102

merged 41 commits into from
Apr 6, 2024

Conversation

DesSnowy
Copy link
Contributor

@DesSnowy DesSnowy commented Apr 6, 2024 •
edited
Loading

Description
This change allows admin to export the top 10 leaderboards entries for both score and popular vote.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Changes done:

  • Added to path to get each type of leaderboard
  • Added new way to render and display the leaderboard to the frontend
  • Added the path to swaggers
  • Add new test cases

DesSnowy added 30 commits March 20, 2024 23:39
@DesSnowy
rename hasTokenCounter to hasVotingFeature under assessmentConfig
2da5101
@DesSnowy
Added hasVotingFeatures to assessment config
fe7854c
@DesSnowy
Added hasVotingFeature to assessmentConfig
d2bfd92
@DesSnowy
Added hasTokenCounter and hasVotingFeatures to assessments
cb18e73
@DesSnowy
hasTokenCounter and hasVotingFeatures to be updated to ones in assess…
6012b11 
…ment config when uploaded
@DesSnowy
Added hasTokenCounter and hasVotingFeatures to be shown when assessme…
ade5541 
…nt is requested
@DesSnowy
Added hasTokenCounter into swaggers
284da06
@DesSnowy
Changed test cases to include hasVotingFeatures and hasTokenCounter
96d1dc7
@DesSnowy
Added a way to change hasTokenCounter and hasVotingFeatures from the …
9687930 
…frontEnd
@DesSnowy
fixed format
0bc2486
@DesSnowy
Merge branch 'source-academy:master' into RenameHasTokenCounterToHasV…
6c5f9e6 
…otingFeatures
@DesSnowy
fixed format
394cb52
@DesSnowy
fixed alias format
49ac07d
@DesSnowy
Merge branch 'RenameHasTokenCounterToHasVotingFeatures' of github.com…
4c059eb 
…:DesSnowy/source-academy-backend into RenameHasTokenCounterToHasVotingFeatures
@DesSnowy
added new function to delete voteSubmissions and call InsertVoting
74dfaed
@DesSnowy
Added ability to reassign voting
41c61a3
@DesSnowy
rename update_voting to reassign_voting for clarity
88f3653
@DesSnowy
added test case for reassign_voting
48205a8
@DesSnowy
rename reassignEntriesForVoting to assignEntriesForVoting
f93efca
@DesSnowy
added isVotingPublished to AssessmentOverview and changed testCases t…
6ee9e46 
…o match
@DesSnowy
fixed format
f625fff
@DesSnowy
Merge branch 'master' into ControlOfInsertVoting
dcde401
@DesSnowy
Moved is_voting_published to be a function in assessments
7b03f68
@DesSnowy
Prevent deletions of submissions if voting has not been published
2c8a332
@DesSnowy
fix format
2339b36
@DesSnowy
fix bug where submission is deleted regardless of reassigning_voting …
293af4b 
…status
@DesSnowy
changed label for better clarity
faec738
@DesSnowy
added new route/endpoint to get contest leaderboards
b989c5f
@DesSnowy
Added new way to display leaderboard
2fdc109
@DesSnowy
fixed format
b2bc496
@DesSnowy
Copy link
Contributor Author

DesSnowy commented Apr 6, 2024

Corresponding frontend PR: source-academy/frontend#2892

@DesSnowy DesSnowy mentioned this pull request Apr 6, 2024
Merged
7 tasks
@coveralls
Copy link

coveralls commented Apr 6, 2024 •
edited
Loading

Coverage Status

coverage: 95.43% (-0.1%) from 95.558%
when pulling ec1c11a on DesSnowy:ExportLeaderboardResult
into 556f7ad on source-academy:master.

@DesSnowy DesSnowy marked this pull request as draft April 6, 2024 06:23
@DesSnowy DesSnowy marked this pull request as ready for review April 6, 2024 09:00
RichDom2185
RichDom2185 reviewed Apr 6, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for working on this! Looks good, just some minor nits regarding renaming and whatnot.

Thanks!

RichDom2185
RichDom2185 approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@RichDom2185 RichDom2185 merged commit 2913e69 into source-academy:master Apr 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DesSnowy @coveralls @RichDom2185