Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign entries for voting #2889

Merged
merged 12 commits into from
Apr 6, 2024

Conversation

jayjay19630
Copy link
Contributor

@jayjay19630 jayjay19630 commented Mar 29, 2024

Description

This change allows admin to control when they wish to assign / reassign entries for voting. Doing so will delete all existing vote submissions and essentially 'reboot' the assignment so that each entry has a fair chance of being voted on.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Mar 29, 2024

Pull Request Test Coverage Report for Build 8545184976

Details

  • 3 of 19 (15.79%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 35.431%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/groundControl/subcomponents/GroundControlConfigureCell.tsx 0 2 0.0%
src/commons/sagas/BackendSaga.ts 1 8 12.5%
src/pages/academy/groundControl/subcomponents/configureControls/AssignEntriesButton.tsx 0 7 0.0%
Totals Coverage Status
Change from base Build 8538649550: -0.04%
Covered Lines: 5175
Relevant Lines: 13628

💛 - Coveralls

@DesSnowy
Copy link

Corresponding backend PR: source-academy/backend#1097

@jayjay19630 jayjay19630 requested a review from RichDom2185 March 30, 2024 04:27
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment on the refactor (abstraction). Otherwise, looks good, thanks!

Approved (in-principle), but as usual, we wait for the backend PR to pass review before merging both at the same time.

@jayjay19630
Copy link
Contributor Author

jayjay19630 commented Apr 1, 2024

I've added a new folder called configureControls, which includes a new AssignEntriesButton.tsx. If any more components need to be added to the panel, they can be organised inside that configureControls folder. I will be adding the exportLeaderboard buttons into this configureControls very soon in another PR.

Also, I've added a new scss module just for these configureControls. Let me know if there are any more issues.

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@RichDom2185 RichDom2185 merged commit ff4206f into source-academy:master Apr 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants