-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign entries for voting #2889
Assign entries for voting #2889
Conversation
Pull Request Test Coverage Report for Build 8545184976Details
💛 - Coveralls |
Corresponding backend PR: source-academy/backend#1097 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment on the refactor (abstraction). Otherwise, looks good, thanks!
Approved (in-principle), but as usual, we wait for the backend PR to pass review before merging both at the same time.
src/pages/academy/groundControl/subcomponents/GroundControlConfigureCell.tsx
Outdated
Show resolved
Hide resolved
…e-academy-frontend into AssignEntriesForVoting
I've added a new folder called configureControls, which includes a new Also, I've added a new scss module just for these configureControls. Let me know if there are any more issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Description
This change allows admin to control when they wish to assign / reassign entries for voting. Doing so will delete all existing vote submissions and essentially 'reboot' the assignment so that each entry has a fair chance of being voted on.
Type of change
Checklist