Fix NaN gain audio

Robust.Shared/Audio/AudioParams.cs

@@ -5,6 +5,9 @@
 using Robust.Shared.Serialization.Manager;
 using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.GameObjects;
+using Robust.Shared.IoC;
+using Robust.Shared.Log;
+using Robust.Shared.Utility;
 
 namespace Robust.Shared.Audio
 {
@@ -29,11 +32,25 @@ public enum Attenuation : int
     [DataDefinition]
     public partial struct AudioParams
     {
+        private float _volume = Default.Volume;
+
         /// <summary>
         ///     Base volume to play the audio at, in dB.
         /// </summary>
         [DataField]
-        public float Volume { get; set; } = Default.Volume;
+        public float Volume
+        {
+            get => _volume;
+            set
+            {
+                if (float.IsNaN(value))
+                {
+                    value = float.NegativeInfinity;
+                }
+
+                _volume = value;
+            }
+        }
 
         /// <summary>
         ///     Scale for the audio pitch.

Robust.Shared/Audio/Systems/SharedAudioSystem.cs

@@ -412,6 +412,13 @@ public void SetVolume(EntityUid? entity, float value, AudioComponent? component
         if (component.Params.Volume.Equals(value))
             return;
 
+        // Not a log error for now because if something has a negative infinity volume (i.e. 0 gain) then subtracting from it can
+        // easily cause this and making callers deal with it everywhere is quite annoying.
+        if (float.IsNaN(value))
+        {
+            value = float.NegativeInfinity;
+        }
+
         component.Params.Volume = value;
         component.Volume = value;
         DirtyField(entity.Value, component, nameof(AudioComponent.Params));