HLA-1323: s_region fix using simplify-polyline #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlwastro
previously requested changes
Sep 23, 2024
Co-authored-by: Rick White <[email protected]>
…hub.com/s-goldman/drizzlepac into hla-1323_s_region_fix_rick_fix_09_23_24
|
While I will continue to test programs that were previously troublesome, this change appears to have fixed the issue. |
s-goldman
added a commit
to s-goldman/drizzlepac
that referenced
this pull request
Oct 1, 2024
Co-authored-by: Rick White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves HLA-1323
This PR fixes the s_region issues that we have been observing in the SVMs. It uses the simplify-polyline package instead of skimage.corner_harris. Results from initial testing are shown in the Jira ticket.
These code changes were generously contributed by @rlwastro.
Checklist for maintainers
CHANGELOG.rstwithin the relevant release sectionHow to run regression tests on a PR
Jenkins test