Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: JenkinsfileRT will open issue on failure, remove stsci.convolve from Jenkins #195

Closed
wants to merge 3 commits into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Nov 21, 2018

JenkinsfileRT (nightly run) will open issue on failure with this patch. Also follow up of #192, where stsci.convolve dependency was removed but that was not reflected in the Jenkins files. cc @rendinam @mcara

@stsci-bot
Copy link

stsci-bot bot commented Nov 21, 2018

Hi there @pllim 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I noticed the following issues with this pull request:

  • The milestone has not been set (this can only be set by a maintainer)
  • Changelog entry not present (or pull request number missing) and neither the Affects-dev nor the no-changelog-entry-needed label are set

Would it be possible to fix these? Thanks!

If there are any issues with this message, please report them here.

@pllim
Copy link
Contributor Author

pllim commented Nov 21, 2018

Errr... @mcara, I thought you removed dependency to stsci.convolve?

ImportError while importing test module '/home/jenkins/workspace/STScI_drizzlepac_PR-195-UC52G7JIC7S4QL52VEO5VEGPOECTEJGGNRKYX6AIPGCREHSSSDTA/tests/acs/test_acs_kernels.py'.

Hint: make sure your test modules/packages have valid Python names.

Traceback:

tests/acs/test_acs_kernels.py:4: in <module>

    import drizzlepac

drizzlepac/__init__.py:45: in <module>

    from . import skytopix

drizzlepac/skytopix.py:80: in <module>

    from . import util,wcs_functions,tweakutils

drizzlepac/tweakutils.py:20: in <module>

    from . import findobj

drizzlepac/findobj.py:15: in <module>

    from stsci import convolve

E   ImportError: cannot import name 'convolve'

@pllim
Copy link
Contributor Author

pllim commented Nov 21, 2018

Note: I can't really unpin pytest due to pytest-dev/pytest#4425 but I would like to hear back on why stsci.convolve is still needed before adding more commits.

@mcara
Copy link
Member

mcara commented Feb 9, 2019

Dependency on stsci.convolve was removed from Jenkinsfile in #225

@pllim
Copy link
Contributor Author

pllim commented Feb 11, 2019

I don't wanna deal with the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants