Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin pytest=3.8.2 and numpy=1.15.2 to pick up latest #2853

Merged
merged 2 commits into from
Dec 1, 2018
Merged

Unpin pytest=3.8.2 and numpy=1.15.2 to pick up latest #2853

merged 2 commits into from
Dec 1, 2018

Conversation

jdavies-st
Copy link
Collaborator

The bugs in pytest 3.9 where the tmpdir fixture was broken seem to be resolved in pytest 3.10, so I'm now unpinning it in our CI and RT build scripts.

@jdavies-st jdavies-st requested a review from nden November 9, 2018 16:09
@hbushouse
Copy link
Collaborator

Partially addresses #2838. Still need to unpin numpy some time.

@hbushouse hbushouse mentioned this pull request Nov 14, 2018
Closed
@jdavies-st jdavies-st requested a review from hbushouse November 15, 2018 03:57
@jdavies-st jdavies-st mentioned this pull request Nov 15, 2018
Merged
@jdavies-st jdavies-st changed the title Unpin pytest=3.8.2 to pick up latest Unpin pytest=3.8.2 and pytest=1.15.2 to pick up latest Nov 15, 2018
@jdavies-st
Copy link
Collaborator Author

jdavies-st commented Nov 15, 2018 •
edited
Loading

Added unpinning numpy to this PR. I've been testing locally with 1.15.4 for a week and it seem fine. astropy has also unpinned their numpy, so we certainly won't get the conda build error anymore in our CI and RT tests.

hbushouse
hbushouse approved these changes Nov 15, 2018
View reviewed changes
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs #2868 to be merged before CI tests will pass.

@hbushouse hbushouse added this to the 0.13.0 milestone Nov 15, 2018
@pllim
Copy link
Collaborator

pllim commented Nov 21, 2018

Try to rerun with pytest 4.0 and see...

@pllim
Copy link
Collaborator

pllim commented Nov 21, 2018

Don't do eeet.... pytest-dev/pytest#4425

@pllim
Copy link
Collaborator

pllim commented Nov 21, 2018

(Also the title is wrong... it should be numpy=1.15...)

@pllim
Copy link
Collaborator

pllim commented Nov 21, 2018

p.p.s. I have nothing against numpy upgrade. But you might want to pin to pytest 3.10 instead of letting it up all the way to 4.0.

@jdavies-st jdavies-st changed the title Unpin pytest=3.8.2 and pytest=1.15.2 to pick up latest Unpin pytest=3.8.2 and numpy=1.15.2 to pick up latest Nov 22, 2018
@jdavies-st
Copy link
Collaborator Author

I've been using pytest 4.0 since it was out, and I've seen no issues with either our CI or RT tests. I suspect whatever bug is listed above, that we don't see that usage in our code. So I'm merging.

@jdavies-st jdavies-st merged commit 10eb087 into spacetelescope:master Dec 1, 2018
@jdavies-st jdavies-st deleted the unpin-pytest branch February 21, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden approved these changes

@hbushouse hbushouse hbushouse approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jdavies-st @hbushouse @pllim @nden