move configuration into pyproject.toml
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyburnett
force-pushed
the
pep621
branch
3 times, most recently
from
9f1eef3 to
d8e6516
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #21 +/- ##
=======================================
Coverage 50.00% 50.00%
=======================================
Files 2 2
Lines 12 12
=======================================
Hits 6 6
Misses 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
zacharyburnett
force-pushed
the
pep621
branch
from
547d797 to
3df3ff8
Compare
zacharyburnett
force-pushed
the
pep621
branch
from
551c302 to
bcbff18
Compare
zacharyburnett
commented
Apr 19, 2023
mcara
requested changes
Apr 19, 2023
|
|
||
| import sys, os | ||
| if sys.version_info < (3, 11): |
There was a problem hiding this comment.
RTD build fails here because of the missing import for sys
|
No other tests for this package, ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptoolsnow supports the[project]table, which is defined by PEP621.Additionally,
setuptoolsnow supports its own entry inpyproject.tomlcalled[tool.setuptools](pypa/setuptools#1688, https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration); however, it comes with the following disclaimer:Reading
tomlis supported natively in Python 3.11 withtomllibGiven this, we can attempt to consolidate the build configuration into a single
pyproject.tomlfile that can possibly be read by other build systems in the future.