Allow null value in translations if allowNullForTranslation is true #488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
When saving a translation with the
null
value an empty string will be returned when retrieving a translation. This behavior was discussed here #195 and was attempted to be fixed here #427 , but caused errors in projects using a string as the default value.These errors were fixed in the PR #465 by adding
allowNullForTranslation
configuration which isfalse
by default.But it still returns an empty string when retrieving a translation with a
null
value. This PR fixes this behavior and returnsnull
instead of an empty string ifallowNullForTranslation
istrue
.