Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groff(1) comment syntax is not supported #63

Closed
alejandro-colomar opened this issue Aug 30, 2021 · 5 comments
Closed

groff(1) comment syntax is not supported #63

alejandro-colomar opened this issue Aug 30, 2021 · 5 comments

Comments

@alejandro-colomar
Copy link

As reported in spdx/license-list-XML#1319, the comment syntax of groff, and therefore that of the man-pages, isn't supported.

The implementation is here:

static final String START_COMMENT_CHAR_PATTERN = "(//|/\\*|\\*|#|' |REM |<!--|--|;|\\(\\*|\\{-)";

groff comments basically start with .\". If I have some time, I'll try and fix it, but in the meantime I'll report it :)

@goneall
Copy link
Member

goneall commented Aug 30, 2021

@alejandro-colomar Can you point me to a a typical document with a license I can use for a test case? I'm working on a new release of the library and may be able to get a fix in before the release.

@alejandro-colomar
Copy link
Author

Yes, I'll look it up tomorrow. Thanks!

@alejandro-colomar
Copy link
Author

alejandro-colomar commented Aug 31, 2021

membarrier.2 seems to be using that license.

You can check it in your system: At least on Debian, you can zcat /usr/share/man/man2/membarrier.2.gz

If you need to download it, you could either clone the man-pages repo and find ./man2/membarrier.2, or you can download just that page from the kernel git website: https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/plain/man2/membarrier.2

@goneall
Copy link
Member

goneall commented Aug 31, 2021

Thanks @alejandro-colomar - I copied the license text and used it for the unit test.

@goneall
Copy link
Member

goneall commented Aug 31, 2021

Resolved with PR #64

@goneall goneall closed this as completed Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants