Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Verbatim-man-pages' license #1319

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Add 'Verbatim-man-pages' license #1319

merged 2 commits into from
Sep 2, 2021

Conversation

alejandro-colomar
Copy link
Contributor

@alejandro-colomar alejandro-colomar commented Aug 22, 2021

@alejandro-colomar
Copy link
Contributor Author

BTW, I removed the incorrect punctuation found in the license website, as discussed in the linked issue.

@seabass-labrax
Copy link
Contributor

Thank you for this pull request, @alejandro-colomar! The tests pass locally on my machine :)

Please could you add the listVersionAdded="3.15" attribute to the <license> tag?

Also, I forgot to mention that we'd need to include markup for the erroneous punctuation. This is because users of LTS distributions might have older versions of the man pages for years to come, and should be able to use SPDX-based license scanning tools to produce their bill of materials. Sorry for not mentioning this earlier! The matching syntax is a little weird (here's an example), so if you'd prefer, we can merge this now and I'll add the matching expressions for the 3.15 release.

Add test too.

Signed-off-by: Alejandro Colomar <[email protected]>
@alejandro-colomar
Copy link
Contributor Author

re: listVersionAdded: Sure, I was about to do it and I forgot to ask you the version, and then forgot it completely... Done :)

re: punctuation: I'll try.

@alejandro-colomar
Copy link
Contributor Author

alejandro-colomar commented Aug 24, 2021

re: punctuation: I give up! I can't make sense of it :p

Please merge, and fix it, and I'll have a look at it later (please CC me).

BTW, I don't know if the groff/man comment syntax is recognized by SPDX tools... And also, there's some wrapper text around the license text in man-pages; you should definitely have a look at it, because it may make SPDX tools go crazy :)

@alejandro-colomar
Copy link
Contributor Author

alejandro-colomar commented Aug 29, 2021

I just noticed that the indentation is quite wrong! BTW, I copied it from BSD-2-Clause (IIRC).
I fixed it to a consistent one, but before uploading, please tell me a few things on how you prefer it:

  • amend or another commit?
  • Any preferred indentation? tabs? spaces? how many?

@goneall
Copy link
Member

goneall commented Aug 29, 2021

BTW, I don't know if the groff/man comment syntax is recognized by SPDX tools... And also, there's some wrapper text around the license text in man-pages; you should definitely have a look at it, because it may make SPDX tools go crazy :)

I just looked at the license matching code and the comment syntax isn't recognized. The comment pattern in implemented in this line in the Spdx-Java-Library.

@goneall
Copy link
Member

goneall commented Aug 29, 2021

Any preferred indentation? tabs? spaces? how many?

Spaces would be preferred - no preferences on the number of spaces.

amend or another commit?

Flexible - but would prefer another commit.

Fix indentation to a consistent one.  Let's use 4 spaces.

Signed-off-by: Alejandro Colomar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New license request: Linux-man-pages-copyleft
5 participants