-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Verbatim-man-pages' license #1319
Conversation
BTW, I removed the incorrect punctuation found in the license website, as discussed in the linked issue. |
Thank you for this pull request, @alejandro-colomar! The tests pass locally on my machine :) Please could you add the Also, I forgot to mention that we'd need to include markup for the erroneous punctuation. This is because users of LTS distributions might have older versions of the man pages for years to come, and should be able to use SPDX-based license scanning tools to produce their bill of materials. Sorry for not mentioning this earlier! The matching syntax is a little weird (here's an example), so if you'd prefer, we can merge this now and I'll add the matching expressions for the 3.15 release. |
Add test too. Signed-off-by: Alejandro Colomar <[email protected]>
re: re: punctuation: I'll try. |
re: punctuation: I give up! I can't make sense of it :p Please merge, and fix it, and I'll have a look at it later (please CC me). BTW, I don't know if the groff/man comment syntax is recognized by SPDX tools... And also, there's some wrapper text around the license text in man-pages; you should definitely have a look at it, because it may make SPDX tools go crazy :) |
I just noticed that the indentation is quite wrong! BTW, I copied it from BSD-2-Clause (IIRC).
|
I just looked at the license matching code and the comment syntax isn't recognized. The comment pattern in implemented in this line in the Spdx-Java-Library. |
Spaces would be preferred - no preferences on the number of spaces.
Flexible - but would prefer another commit. |
Fix indentation to a consistent one. Let's use 4 spaces. Signed-off-by: Alejandro Colomar <[email protected]>
Fixes #1310
@jlovejoy
@seabass-labrax
@swinslow