Match erroneous punctuation in Verbatim-man-pages #1331
Conversation
The trailing characters in the license text are likely to be removed upstream. However, as users of SPDX may wish to run automated license matchers on older files, this commit adds `alt` elements to match license texts containing the erroneous punctuation.
|
@goneall, I've checked the test output locally, and I'm a little concerned that the
|
|
@seabass-labrax Looks like an issue with the LicenseListPublisher - I'll look into it after I finish up some of my Docfest tasks - may take a couple days. |
|
I created a pull request which resolves this issue: spdx/LicenseListPublisher#122 I just added simple spaces to the HTML rather than using I plan on updating the version used to publish the website before the next license list release - this is tracked in issue #1323 Here's the output from the fixed LicenseListPublisher:
|
|
Thank you, @goneall! I had looked in that file and found https://github.com/spdx/LicenseListPublisher/blob/cdb270cb95f2e1bb4517c2191d81f969aa4fb43c/src/org/spdx/licensexml/LicenseXmlHelper.java#L350-L353, but that turned out to be just for the optional text and not for replaceable text! Maybe we should combine the code into a single function that takes Element (be it @swinslow, @jlovejoy - this pull request is now ready to merge! :) |
The trailing characters in the license text are likely to be removed upstream. However, as users of SPDX may wish to run automated license matchers on older files, this commit adds
altelements to match license texts containing the erroneous punctuation.Related to issue #1310 and pull request #1319.