Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the isDeprecated field form the licenses #1862

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

BassCoder2808
Copy link
Contributor

Fixes #1545
Compared all the licenses in the src folder and src/exceptions folder and removed the isDeprecated field from the XML format as each license had deprecatedVersion field

@swinslow
Copy link
Member

swinslow commented Mar 7, 2023

Looks good to me, thank you @BassCoder2808! Merging now.

@swinslow swinslow added this to the 3.21 milestone Mar 7, 2023
@swinslow swinslow added the XML markup change potential change or addition to XML markup in license label Mar 7, 2023
@swinslow swinslow merged commit 7f5bb57 into spdx:main Mar 7, 2023
@goneall
Copy link
Member

goneall commented Mar 7, 2023

Just FYI - I checked and indeed the deprecated fields are being handled properly in the license list data JSON files after this PR. It all looks good.

@swinslow
Copy link
Member

swinslow commented Mar 7, 2023

Thank you @goneall! I had left this browser tab open with the intent to go back and check later -- thanks for beating me to it ;-)

BassCoder2808 added a commit to BassCoder2808/license-list-XML that referenced this pull request Mar 8, 2023
Merge pull request spdx#1862 from BassCoder2808/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
XML markup change potential change or addition to XML markup in license
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up isDeprecated values
3 participants