Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more license urls #2678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add more license urls #2678

wants to merge 1 commit into from

Conversation

joerg1985
Copy link

Here are some more URL mappings, please add them to your lists.

https://www.eclipse.org/legal/epl-v20.html used by org.junit.jupiter:junit-jupiter-api:5.12.0
https://projects.eclipse.org/license/epl-2.0 used by jakarta.json:jakarta.json-api:2.1.3
http://opensource.org/licenses/MIT used by org.checkerframework:checker-qual:3.49.1

@@ -3,6 +3,7 @@
<license isOsiApproved="true" licenseId="MIT" name="MIT License">
<crossRefs>
<crossRef>https://opensource.org/license/mit/</crossRef>
<crossRef>http://opensource.org/licenses/MIT</crossRef>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are the same url (the content is the same).

@@ -5,6 +5,8 @@
<crossRefs>
<crossRef>https://www.eclipse.org/legal/epl-2.0</crossRef>
<crossRef>https://www.opensource.org/licenses/EPL-2.0</crossRef>
<crossRef>https://www.eclipse.org/legal/epl-v20.html</crossRef>
<crossRef>https://projects.eclipse.org/license/epl-2.0</crossRef>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just redirect to the url we have above.

@xsuchy
Copy link
Collaborator

xsuchy commented Mar 6, 2025

Closing as spam.

@xsuchy xsuchy closed this Mar 6, 2025
@joerg1985
Copy link
Author

@xsuchy some more context on this, i am trying to add them, to allow the https://github.com/spdx/spdx-maven-plugin to detect them. The plugin does not resolve the URLs and should not, as the plugin might run in a offline environment.

@goneall is this the correct repo?

@xsuchy
Copy link
Collaborator

xsuchy commented Mar 7, 2025

some more context on this, i am trying to add them, to allow the https://github.com/spdx/spdx-maven-plugin to detect them.

Can you reference the issue in spdx-maven-plugin so it is clear what you are trying to achieve? I still have no clue.

@joerg1985
Copy link
Author

joerg1985 commented Mar 7, 2025

@xsuchy sure this is the issue comment: spdx/spdx-maven-plugin#180 (comment)
In a nutshell: The spdx-maven-plugin is used to generate a SBOM out of your maven POM, the mapping of licenses to SPDX identifiers is done using the URLs. So i am trying to add new URLs used in different POMs to make the mapping work.

@xsuchy
Copy link
Collaborator

xsuchy commented Mar 7, 2025

Ah. I see.
But the URL matching method is wrong. Very wrong. We cannot have full list of all URL where is the license used or even defined. Not even full, not even comprehensive. And I am afraid not even representative in some cases.

@goneall
Copy link
Member

goneall commented Mar 7, 2025

Ah. I see. But the URL matching method is wrong. Very wrong. We cannot have full list of all URL where is the license used or even defined. Not even full, not even comprehensive. And I am afraid not even representative in some cases.

@xsuchy - I agree with you comment that we can not have a full list of all URLs, but we can use the limited set of URLs to provide matching. We've been using this method in a few utilities since the inception of the SPDX license list.

The reason this is important is other methods of matching is even less reliable (e.g. matching based on whatever the maintainer puts in as a "license name".

Of course, if everyone uses license ID's this wouldn't be needed - unfortunately license IDs are not pervasively used in the case of Maven.

@goneall goneall reopened this Mar 7, 2025
@goneall
Copy link
Member

goneall commented Mar 7, 2025

A bit more history and context for the license URLs.

There's been quite a bit of discussion on the use of the URLs and in the past we've agreed it can be used to match licenses. This is what led to the policy of not deleting URLs that are no longer live.

We've enhanced the license list publisher to check the status of the URLs. It will check if the URL is live, if it is a wayback link, and if it actually contains text that matches the license per the license matching guidelines. All of this information is recorded in the crossRefs field in the JSON (e.g. https://github.com/spdx/license-list-data/blob/d5f85740b2cd68f84672743987bc02c1408c48a0/json/details/EPL-2.0.json#L10)

When we render the HTML for spdx.org/licenses, we retain the order so the first license should always be the closest to canonical. If the license is no longer live - we append the url with a "[not live]" note.

Since merging this will enhance the license data captured by the SPDX Maven plugin, I would like to merge this PR.

@xsuchy - let me know if you'd like to discuss prior to merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants