Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPIRE Server does not support binding to hostname #3421

Closed
mchurichi opened this issue Sep 13, 2022 · 1 comment · Fixed by #3479
Closed

SPIRE Server does not support binding to hostname #3421

mchurichi opened this issue Sep 13, 2022 · 1 comment · Fixed by #3479
Labels
good first issue Issues with this label are good candidates for first-time contributions help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog

Comments

@mchurichi
Copy link
Member

SPIRE Server help says it supports binding to a DNS name, but it fails when passing in localhost, is this right?

$ bin/spire-server run -h                    
Usage of run:
  -bindAddress string
        IP address or DNS name of the SPIRE server

$ bin/spire-server run -bindAddress localhost
could not parse bind_address "localhost"
  • Version: 8a5b108
  • Platform: Darwin workstation.local 21.6.0 Darwin Kernel Version 21.6.0: Sat Jun 18 17:07:25 PDT 2022; root:xnu-8020.140.41~1/RELEASE_X86_64 x86_64
  • Subsystem: server
@azdagron
Copy link
Member

Looks like an oversight. Code calls net.ParseIP, when it should probably combine the BindAddress and BindPort and pass it to net.ResolveTCPAddr

@azdagron azdagron added help wanted Issues with this label are ready to start work but are in need of someone to do it good first issue Issues with this label are good candidates for first-time contributions priority/backlog Issue is approved and in the backlog labels Sep 14, 2022
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 5, 2022
@guilhermocc
Resolve provided spire-server bind address (spiffe#3421)
5e84151 
Signed-off-by: Guilherme Carvalho <[email protected]>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 5, 2022
@guilhermocc
Resolve provided spire-server bind address (spiffe#3421)
e062c35
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 5, 2022
@guilhermocc
Resolve provided spire-server bind address (spiffe#3421)
9949aff 
Signed-off-by: Guilherme Carvalho <[email protected]>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 5, 2022
@guilhermocc
Resolve provided spire-server bind address (spiffe#3421)
b20b035 
Signed-off-by: Guilherme Carvalho <[email protected]>
@guilhermocc guilhermocc mentioned this issue Oct 5, 2022
Merged
3 tasks
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 5, 2022
@guilhermocc
Fix error message typo and add extra test case for hostname address (s…
a5b251e 
…piffe#3421)

Signed-off-by: Guilherme Carvalho <[email protected]>
guilhermocc added a commit to guilhermocc/spire that referenced this issue Oct 5, 2022
@guilhermocc
Improve code style, rename var (spiffe#3421)
bd1d56e 
Signed-off-by: Guilherme Carvalho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues with this label are good candidates for first-time contributions help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve provided spire-server bind address (#3421) guilhermocc/spire
2 participants
@mchurichi @azdagron