Remove webhook mode from k8s-workload-registrar #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
azdagron
force-pushed
the
remove-deprecated-webhook-mode
branch
from
9a1d6cf to
77a9c9d
Compare
This was deprecated in 1.3.0. Removing for 1.4.0. Signed-off-by: Andrew Harding <[email protected]>
azdagron
force-pushed
the
remove-deprecated-webhook-mode
branch
from
77a9c9d to
d58e3cc
Compare
| `insecure_skip_client_verification` configurable) unless you fully understand | ||
| the risks. | ||
|
|
||
| #### Migrating away from the webhook |
There was a problem hiding this comment.
Is it worth keeping some info on migration for users that are still on the webhook mode?
There was a problem hiding this comment.
Oh sure. That's probably a good idea.
There was a problem hiding this comment.
I moved it into a "troubleshooting" section on the CRD mode docs. Hope that spot makes sense.
MarcosDY
reviewed
Jul 12, 2022
| @@ -31,19 +31,9 @@ The configuration file is a **required** by the registrar. It contains | |||
| | `cluster` | string | required | Logical cluster to register nodes/workloads under. Must match the SPIRE SERVER PSAT node attestor configuration. | | | |||
| | `pod_label` | string | optional | The pod label used for [Label Based Workload Registration](#label-based-workload-registration) | | | |||
| | `pod_annotation` | string | optional | The pod annotation used for [Annotation Based Workload Registration](#annotation-based-workload-registration) | | | |||
| | `mode` | string | optional | How to run the registrar, either using a `"webhook"`, `"reconcile`" or `"crd"`. See [Differences](#differences-between-modes) for more details. | `"webhook"` | | |||
| | `mode` | string | required | How to run the registrar, either `"reconcile`" or `"crd"`. See [Differences](#differences-between-modes) for more details. | | | |||
There was a problem hiding this comment.
Suggested change
| | `mode` | string | required | How to run the registrar, either `"reconcile`" or `"crd"`. See [Differences](#differences-between-modes) for more details. | | | |
| | `mode` | string | required | How to run the registrar, either `"reconcile"` or `"crd"`. See [Differences](#differences-between-modes) for more details. | | |
| }, | ||
| }, | ||
| { | ||
| name: "overrides", | ||
| in: ` | ||
| mode = "reconcile" | ||
| log_level = "LEVELOVERRIDE" | ||
| log_path = "PATHOVERRIDE" | ||
| addr = ":1234" |
There was a problem hiding this comment.
are not those configs removed?
addr = ":1234"
cert_path = "CERTOVERRIDE"
key_path = "KEYOVERRIDE"
cacert_path = "CACERTOVERRIDE"
insecure_skip_client_verification
There was a problem hiding this comment.
Oh yep, thanks, i'll clean these up.
Signed-off-by: Andrew Harding <[email protected]>
goergch
pushed a commit
to goergch/spire
that referenced
this pull request
Jul 26, 2022
* Remove webhook mode from k8s-workload-registrar This was deprecated in 1.3.0. Removing for 1.4.0. Signed-off-by: Andrew Harding <[email protected]> * Address PR comments Signed-off-by: Andrew Harding <[email protected]> Signed-off-by: Christian Görg <[email protected]>
stevend-uber
pushed a commit
to stevend-uber/spire
that referenced
this pull request
Oct 16, 2023
* Remove webhook mode from k8s-workload-registrar This was deprecated in 1.3.0. Removing for 1.4.0. Signed-off-by: Andrew Harding <[email protected]> * Address PR comments Signed-off-by: Andrew Harding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was deprecated in 1.3.0. Removing for 1.4.0.